Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu item for MozcTool lacks text label in ibus-mozc #233

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 1 comment
Closed

Menu item for MozcTool lacks text label in ibus-mozc #233

GoogleCodeExporter opened this issue Apr 22, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 22, 2015

What steps will reproduce the problem?
1. Install Mozc 1.15.1824.102 into Fedora 20.
2. Select Mozc from Region & Language.
3. Clock input method selector on the top notification area.

What is the expected output?
"Tools" should be displayed as a parent element of "Properties", "Dictionary 
Tool", and so on.

What do you see instead?
A blank item is displayed as a parent element of "Properties", "Dictionary 
Tool", and so on.  See the attached screen shots.

This is actually a remaining task of Issue 182, but somehow not addressed yet.  
See also Red Hat Bugzilla 920122 
https://bugzilla.redhat.com/show_bug.cgi?id=920122 for the detailed background.

The root cause is the lack of text label in ibus-mozc here.
https://code.google.com/p/mozc/source/browse/trunk/src/unix/ibus/property_handle
r.cc?r=192#275
>  const string icon_path = GetIconPath(kMozcToolIconPath);
>  prop_mozc_tool_ = ibus_property_new("MozcTool",
>                                      PROP_TYPE_MENU,
>                                      NULL /* label */,
>                                      icon_path.c_str(),
>                                      NULL /* tooltip */,
>                                      TRUE /* sensitive */,
>                                      TRUE /* visible */,
>                                      PROP_STATE_UNCHECKED,
>                                      sub_prop_list);

Specifying some text label for this item resolves the issue.

Original issue reported on code.google.com by yukawa@google.com on 5 Jul 2014 at 2:44

Attachments:

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 22, 2015

This issue was closed by revision r251.

Original comment by yukawa@google.com on 5 Jul 2014 at 2:52

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.