New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'icon_prop_key' entry in ibus-mozc #344

Closed
yukawa opened this Issue Jan 3, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@yukawa
Member

yukawa commented Jan 3, 2016

Environment

ibus-mozc 2.17.2287.103 running on Fedora 23 KDE Plasma Desktop.

Steps to reproduce:

  1. Build and install ibus-mozc 2.17.2287.103.
  2. Make sure that ibus-mozc is selected as the current input method.
  3. Make sure that the setting Show icon on system tray is enabled on the ibus-setting dialog.
  4. Focus in any text field.

Expected behavior:

Status icon such as and A is displayed on the KDE5 system tray.

Hiragana Mode

hiragana

Katakana Mode

katakana

Direct Mode

off

Actual behavior:

Mozc's product icon ime_product_icon_opensource-32.png is displayed on the KDE5 system tray.

actual

Additional Information:

Showing a status icon instead of the IME's product icon is a new feature introduced by ibus/ibus@23c45b9 and has been available since IBus 1.5.11.

Basically all we need to do is just to add <icon_prop_key> entry in mozc.xml when IBus is 1.5.11 or greater. Although supporting new IBus feature is not our goal any more, doing this before we delete ibus-mozc in #287 may help some people.

@yukawa yukawa added the OpSys-Linux label Jan 3, 2016

@yukawa yukawa self-assigned this Jan 3, 2016

yukawa added a commit that referenced this issue Jan 10, 2016

Support 'icon_prop_key' entry in ibus-mozc.
Fixes #344.

Showing a status icon instead of the IME's product icon is a new feature
introduced by ibus/ibus@23c45b9 and has
been available since IBus 1.5.11.

Although supporting new IBus feature is not our goal any more,
supporting his feature before we delete ibus-mozc in #287 may help some
people.

BUG=#344
TEST=manually done on Fedora 23 KDE Plasma Desktop.
REF_BUG=
REF_CL=111381977

yukawa added a commit that referenced this issue Jan 10, 2016

Support 'icon_prop_key' entry in ibus-mozc.
Fixes #344.

Showing a status icon instead of the IME's product icon is a new feature
introduced by ibus/ibus@23c45b9 and has
been available since IBus 1.5.11.  Hence this CL adds 'icon_prop_key' to
mozc.xml when the IBus version is 1.5.11 or later.

Although supporting new IBus feature is not our goal any more,
supporting his feature before we delete ibus-mozc in #287 may help some
people.

One thing you should keep in mind is that the version of IBus is checked
at build time, not run-time.  This means that if you upgrade IBus from
1.5.10 or prior to 1.5.11 or later then you have to rebuild ibus-mozc so
that mozc.xml can be updated.

BUG=#344
TEST=manually done on Fedora 23 KDE Plasma Desktop.
REF_BUG=
REF_CL=111381977

@yukawa yukawa closed this in #354 Jan 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment