Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #462

Open
Arfrever opened this issue Apr 1, 2019 · 3 comments
Open

Support Python 3 #462

Arfrever opened this issue Apr 1, 2019 · 3 comments

Comments

@Arfrever
Copy link

@Arfrever Arfrever commented Apr 1, 2019

Python 2.7 will be discontinued by upstream in 9 months, on 2020-01-01. See https://pythonclock.org/.
Python code in Mozc should be ported to Python 3.

@Keruspe

This comment has been minimized.

Copy link

@Keruspe Keruspe commented Oct 9, 2019

Any progress on this?

@Keruspe Keruspe mentioned this issue Dec 4, 2019
@Arfrever

This comment has been minimized.

Copy link
Author

@Arfrever Arfrever commented Jan 10, 2020

Patch: mozc-2.23.2815.102-python-3.patch.txt

Patch removes support for Python 2.7, which is no longer supported by Python upstream.
Patch successfully tested on GNU/Linux system.

Besides files actually used on GNU/Linux system:

  • src/android/gen_emoji_data.py tested and seems to work.
  • src/android/gen_emoticon_data.py tested and seems to work.
  • src/android/gen_mozc_drawable.py tested and seems to work.
  • src/android/gen_touch_event_stats.py operates on statistics unavailable in Mozc open-source repository (src/android/collected_keyboards.csv and src/data/typing/touch_event_stats.csv are almost empty), so this script creates only empty directory.
  • src/android/run_android_test.py cannot be tested without Android-related tools (e.g. adb) and device (INFO:user:All the activated devices are [], INFO:user:No devices are specified. Do nothing.).
  • src/chrome/nacl/nacl_net_test_server.py not tested.
  • src/chrome/nacl/pnacl_translate.py not tested.
  • src/chrome/nacl/run_nacl_test.py not tested.
  • src/client/gen_client_quality_test_data.py not normally used anywhere but manually tested and seems to work.
  • src/data/test/calculator/gen_test.py not normally used anywhere but manually tested and seems to work.
  • src/mac/generate_mapping.py tested and seems to work.
  • src/win32/installer/postbuilds_win.py is broken on Windows (NameError: name 'PostProcessOnWindows' is not defined) and does nothing on non-Windows.
@utuhiro78

This comment has been minimized.

Copy link

@utuhiro78 utuhiro78 commented Jan 13, 2020

Thanks Arfrever, your patch works fine on Arch Linux.
I posted new PKGBUILD to https://bugs.archlinux.org/task/65124 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.