Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update HTTP server write timeout to 5 seconds #908

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

terencehonles
Copy link
Contributor

This change updates the HTTP server's write timeout to 5 seconds to ensure the exporters have enough time to write their output.

This change updates the HTTP server's write timeout to 5 seconds to
ensure the exporters have enough time to write their output.
@terencehonles
Copy link
Contributor Author

@jaqx0r 1 second was a little too short for both the JSON and prometheus exporters for some logs I was testing against. It looks like 2 seconds would have been fine, but I figured bumping up to 5 wasn't a problem. If you think this should be a command line argument I can propose that change instead.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.52%. Comparing base (dd0f4da) to head (06d5ac8).
Report is 229 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   56.76%   57.52%   +0.76%     
==========================================
  Files          66       68       +2     
  Lines        6923     6908      -15     
==========================================
+ Hits         3930     3974      +44     
+ Misses       2724     2669      -55     
+ Partials      269      265       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaqx0r jaqx0r enabled auto-merge August 5, 2024 23:09
@jaqx0r
Copy link
Contributor

jaqx0r commented Aug 5, 2024

Thanks! I don't think we need a flag for it.

This might help with #903 though I suspect the root cause there is iterating over the entire store.

@jaqx0r jaqx0r added this pull request to the merge queue Aug 5, 2024
Merged via the queue into google:main with commit d4b8a71 Aug 5, 2024
20 checks passed
@terencehonles terencehonles deleted the update-write-timeout branch August 6, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants