Skip to content
Permalink
Browse files

Export Weimin as author of commits to GitHub

Also adds Guy to list of CONTRIBUTORS and removes Xooglers (who definitely won't be contributing more code).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=202476218
  • Loading branch information...
CydeWeys authored and jianglai committed Jun 28, 2018
1 parent bb1b4bc commit 513f2ad72ebbe585700b1b4a24372b2e76871dc0
@@ -30,3 +30,5 @@ Jordyn Buchanan <jordyn@google.com>
Wolfgang Meyers <wolfgang@donuts.co>
Hans Ridder <hans.ridder@gmail.com>
Justin Graham <justin.af.graham@gmail.com>
Guy Bensky <guyben@google.com>
Weimin Yu <weiminyu@google.com>
@@ -59,6 +59,7 @@ static Dns provideDns(
@IntoMap
@StringKey(CloudDnsWriter.NAME)
abstract DnsWriter provideWriter(CloudDnsWriter writer);

@Provides
@IntoSet
@Named("dnsWriterNames")
@@ -110,12 +110,12 @@ public String execute() throws Exception {
return extractServerResponse(response);
}

// TODO(tjb): refactor this behavior into a better general-purpose
// TODO(user): refactor this behavior into a better general-purpose
// response validation that can be re-used across the new client/server commands.
String extractServerResponse(String response) {
Map<String, Object> responseMap = toMap(JSONValue.parse(stripJsonPrefix(response)));

// TODO(tjb): consider using jart's FormField Framework.
// TODO(user): consider using jart's FormField Framework.
// See: j/c/g/d/r/ui/server/RegistrarFormFields.java
String status = (String) responseMap.get("status");
Verify.verify(!status.equals("error"), "Server error: %s", responseMap.get("error"));
@@ -128,7 +128,7 @@ String extractServerResponse(String response) {
return (Map<String, Object>) obj;
}

// TODO(tjb): figure out better place to put this method to make it re-usable
// TODO(user): figure out better place to put this method to make it re-usable
static String stripJsonPrefix(String json) {
Verify.verify(json.startsWith(JSON_SAFETY_PREFIX));
return json.substring(JSON_SAFETY_PREFIX.length());
@@ -26,7 +26,6 @@ java_library(
"//java/google/registry/ui/soy/registrar:soy_java_wrappers",
"//java/google/registry/util",
"//third_party/objectify:objectify-v4_1",
"@com_braintreepayments_gateway_braintree_java",
"@com_google_appengine_api_1_0_sdk",
"@com_google_code_findbugs_jsr305",
"@com_google_dagger",
@@ -25,7 +25,6 @@ java_library(
"//javatests/google/registry/security",
"//javatests/google/registry/testing",
"//third_party/objectify:objectify-v4_1",
"@com_braintreepayments_gateway_braintree_java",
"@com_google_appengine_api_1_0_sdk",
"@com_google_flogger",
"@com_google_flogger_system_backend",

0 comments on commit 513f2ad

Please sign in to comment.
You can’t perform that action at this time.