Permalink
Browse files

Collect proxy backend metrics

The metrics are collected in a new handler (BackendMetricsHandler), which gets outbound FullHttpRequest and inbound FullHttpResponse. All metrics collected here are backend metrics, i. e. metrics about connection between the proxy and GAE. They also corresponds to the metrics that we are correctly collection from the [] proxy, minus a few that are related to quota management, which are yet to be implemented.

This CL also removed some unnecessary steps to write the frontend protocol name and client hash certificate into backend channel attributes. Instead, BackendMetricsHandler will read these information from the frontend channel attributes directly. This is because backend channel is established after frontend channel, and reading frontend channel attributes from backend handlers always works. On the other hand, there is no easy way to guarantee that the backend channel attributes are writable from frontend handlers, because the channel itself may not have been fully established.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=174513334
  • Loading branch information...
jianglai committed Nov 3, 2017
1 parent 5b8ee87 commit a6f0ab1429f9063b023106f0b21cec23833ed3a8
Showing with 4 additions and 4 deletions.
  1. +4 −4 java/google/registry/monitoring/metrics/contrib/DistributionMetricSubject.java
@@ -105,10 +105,10 @@ protected String getMessageRepresentation(Distribution distribution) {
/**
* Asserts that the distribution for the given label can be constructed from the given data set.
*
* <p>Note that this only tests that the distribution has the same binned histogram as it would if
* it had recorded the specified data points. It could have in fact collected different data
* points that resulted in the same histogram, but that information is lost to us and cannot be
* tested.
* <p>Note that this only tests that the distribution has the same binned histogram, along with
* the same mean, and sum of squared deviation as it would if it had recorded the specified data
* points. It could have in fact collected different data points that resulted in the same
* distribution, but that information is lost to us and cannot be tested.
*/
public And<DistributionMetricSubject> hasDataSetForLabels(
ImmutableSet<? extends Number> dataSet, String... labels) {

0 comments on commit a6f0ab1

Please sign in to comment.