Permalink
Branch: master
Commits on Feb 14, 2019
  1. Clean up the Gradle JS distribution a bit

    gbrodman authored and jianglai committed Feb 14, 2019
    There's no reason not to always create the source mapping but we shouldn't
    distribute it in production.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=233984970
Commits on Feb 11, 2019
  1. Add source maps in to the JS output

    gbrodman authored and jianglai committed Feb 8, 2019
    This allows us to have the source mapping appear when debugging, just like we have when logging on to alpha, prod, or locally.
    
    Tested on Crash with building from Gradle
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=233092769
Commits on Feb 8, 2019
  1. Add the Closure Compiler/Library/Templates dependencies

    gbrodman committed Feb 8, 2019
    This CL does a few things:
    - Adds the template Soy-to-JS compilation (note: this requires the extra
      soyutils_usegoog.js file separately so that the compiled *.soy.js files work
    - Adds the Closure Compiler to compile and check our JS
    - Adds an NPM task to allow us to download dependencies
    - Adds the Closure library as an NPM package
    
    Note: this probably won't compile until we fix the test JS files
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=233059414
Commits on Feb 6, 2019
  1. Handle sunrise reservations properly during sunrise TLDs

    gbrodman authored and jianglai committed Feb 6, 2019
    We figure out the TLD state so that we properly check whether or not we can provision sunrise domains in that TLD. We also change the message slightly so that it's a bit more clear when we aren't in sunrise.
    
    Note: it is deliberate that NAME_COLLISION reservations are provisionable in sunrise.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=232742813
  2. Run more formatting fixes in preparation for the open-source change

    gbrodman authored and jianglai committed Feb 5, 2019
    Similar to [] these are issues found by Google Java Format. Most of the output is just using the standard [] formatter, then fixing any line-length issues.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=232488284
  3. Fix some style issues that will help us out later

    gbrodman authored and jianglai committed Feb 4, 2019
    These files will have errors later when we run the Google Java Format plugin over their entirety (e.g. a situation where fixed indentation leads to a line that's longer than 100 characters). It's simpler to fix them now so we won't have to fix them later.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=232353791
Commits on Jan 31, 2019
  1. Pass the date field in to the Spec11 Soy template

    gbrodman authored and mindhog committed Jan 28, 2019
    The daily template is the only one that needs it but we can always pass it in without issue.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=231295089
  2. Add Checkstyle and Error Prone to the Gradle build

    gbrodman authored and mindhog committed Jan 28, 2019
    We make some modifications to the internal Google checkstyle file because Google's linter uses a modified build of Checkstyle that introduces some new classes and allows for more specific checks than the open-source Checkstyle (e.g. only enforcing UPPER_SNAKE_CASE on deeply immutable fields). There exists a public Checkstyle file that purports to be the Google java format file (https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml) but it doesn't quite match up with what the internal linter says in certain situations (e.g. what operators must/can appear on new lines).
    
    The suppressions are basically "don't run on generated code + don't care about Javadoc in test code"
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=231283700
Commits on Jan 28, 2019
  1. Make a prettier table to display OT&E check results

    gbrodman authored and CydeWeys committed Jan 26, 2019
    We now display the results of each check in addition to the overall result.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=231051913
  2. Fix various Error Prone errors that were found by the FOSS build

    gbrodman authored and CydeWeys committed Jan 25, 2019
    Most common:
    - Unnecessary parentheses and operator precedence clarify (self-explanatory)
    - Reference equality--there were a few instances of using == or != improperly
    - Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to
    - Marking some immutable classes with @immutable since EP desires that all enums be deeply immutable
    - String.split() having "surprising behavior"
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=230971531
Commits on Jan 25, 2019
  1. Fix a few stylistic issues in preparation for Checkstyle addition

    gbrodman authored and jianglai committed Jan 23, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=230524735
Commits on Jan 18, 2019
  1. Add a button in the admin panel to check OT&E status of a registrar

    gbrodman authored and CydeWeys committed Jan 18, 2019
    For now, it only displays a status of "Passed: true|false" or an error message in simple text. In further work we will make the UI nicer.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229971564
Commits on Jan 14, 2019
  1. Add diff logic and send daily Spec11 emails with new threats

    gbrodman authored and CydeWeys committed Jan 11, 2019
    For each registrar, the daily email will only include threats that did not appear
    in the prior run's email.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228889972