Skip to content
Permalink
Branch: master
Commits on May 13, 2019
  1. Save the RDAP request time globally instead of passing it around

    guyben13 authored and jianglai committed May 10, 2019
    Also removed the rdapWhoisServer value, as it's just null and will likely stay that way (it isn't mentioned in the RDAP response profile)
    
    If it'll ever become required, we can add it back.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247643981
  2. Convert RDAP tests from simple.json to Gson

    guyben13 authored and jianglai committed May 8, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247237275
  3. Inject RdapAuthorization

    guyben13 authored and jianglai committed May 7, 2019
    We currently create it from injected arguments, and pass it to every function.
    
    Instead, we just create a provider for it and inject it where needed.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=247072517
  4. Reimplement the RDAP Json creation using Jsonables

    guyben13 authored and jianglai committed May 7, 2019
    Currently we try to reimplemnet the same behavior of the existing code as much
    as possible.
    
    We only fix issues that go against the RFC7483, but we don't yet update the
    code to follow the latest (15feb19) RDAP Response Profile. That will require a
    much bigger change especially for the test files, so it'll wait for a followup
    CL.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246948018
Commits on May 6, 2019
  1. Fix Kokoro failure

    guyben13 authored and jianglai committed May 2, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246411007
  2. Add Jsonable and AbstractJsonableObject for easier RDAP object building

    guyben13 authored and jianglai committed May 2, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246345611
  3. Simplify some of the RDAP Action classes

    guyben13 authored and jianglai committed May 1, 2019
    Overriding getter methods to change values is a bit overkill when these values
    are static (don't change based on internal state).
    
    Just setting them in the base class' constructor is simpler.
    
    Also, we can read the PATH of an Action based on the Annotation instead
    returning it manually for each Action.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=246135754
Commits on Apr 11, 2019
  1. Add abuse entity to registrar entities

    guyben13 authored and jianglai committed Apr 9, 2019
    From to the RDAP response profile:
    
    2.4.5. Abuse Contact (email, phone) - an RDAP server MUST include an *entity*
    with the *abuse* role within the registrar *entity* which MUST include *tel*
    and *email*, and MAY include other members
    
    Even though this is a MUST - this field will only be shown if the registrar has a *visible* abuse contact.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=242684303
  2. Show only the last of each event type in RDAP domain response

    guyben13 authored and jianglai committed Apr 8, 2019
    We also ignore events that happened before the domain was created (for example, in a previous incarnation of the same domain name) and we set the last changed event to be the later of the last EPP change and any other event that happened before "now".
    
    From RDAP response profile
    2.3.2 The domain object in the RDAP response MAY contain the following events:
    2.3.2.3 An event of *eventAction* type *transfer*, with the last date and time that the
    domain was transferred. The event of *eventAction* type *transfer* MUST be omitted if
    the domain name has not been transferred since it was created.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=242461310
Commits on Apr 5, 2019
  1. Update the rdapConformance and notices fields

    guyben13 authored and jianglai committed Apr 2, 2019
    We're changing rdapConformance from rdap_level_0 to icann_rdap_response_profile_0, and changing the EPP status notices title from "EPP Status Codes" to "Status Codes" to conform with the changing spec.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=241527211
Commits on Mar 29, 2019
  1. Consolidate domain_info_fee xml test files

    guyben13 authored and jianglai committed Mar 25, 2019
    This removes a LOT of "almost duplicate" test files, and moves some of the info into the java test itself making it clearer what's actually different between tests.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=240230982
  2. Consolidate the domain_renew_fee xml test files

    guyben13 authored and jianglai committed Mar 25, 2019
    Moving some of the info into the java test file itself makes it more easily readable. Maybe.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=240148747
Commits on Mar 20, 2019
  1. Add ability to save report to local folder

    guyben13 authored and CydeWeys committed Mar 12, 2019
    Updated the plugin to receive the "protocol"-like tag in the destination, so that you can choose whether to upload to GCS or just save it locally.
    
    Possibly we might expand this in the future, but for now the goal was to allow saving our "internal" builds locally until we find a secure way to store AND BROWSE them remotely.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=238055136
  2. Set the travis CI build to continue even if some tasks failed

    guyben13 authored and CydeWeys committed Mar 11, 2019
    The --continue argument makes gradle try and build every task whose dependencies finished successfully. This is in contrast to the "regular" behavior of stopping at the first failure.
    
    This is useful because it will show us all the failed tests (from all test tasks) instead of just the first test task that failed.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=237792667
Commits on Mar 5, 2019
  1. Remove the web console EPP endpoint

    guyben13 authored and weiminyu committed Mar 1, 2019
    This removes the "create Domain/Host/Contact" forms that were supposed to be used instead of regular EPPs for CC-TLD that wanted to support it.
    
    We're removing it because we don't use it and want to reduce unneeded code for the registry 3.0 migration.
    
    Also, this is a security risk, as it allowed to do "billable actions" (creating a new domain for example) with the only authentication being access to the registrar's G Suite account.
    
    This bypassed the certificate, IP whitelist, and EPP password, which is bad.
    
    PUBLIC:
    Remove the web console EPP endpoint
    
    This removes the "create Domain/Host/Contact" forms that were supposed to be used instead of regular EPPs for CC-TLD that wanted to support it.
    
    We're removing it because we don't use it and want to reduce unneeded code for the registry 3.0 migration.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=236244195
  2. Zip report folders that don't have a clear entry point

    guyben13 authored and weiminyu committed Feb 28, 2019
    This is mostly for build reports that use xml or other non-browsable
    format. Most notable - the JUnit xml test results.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=236118885
  3. Set the registrar WHOIS email in the web console creation endpoint

    guyben13 authored and weiminyu committed Feb 26, 2019
    We set the initial value to the "icann referral email", but registrars can change it later if they want.
    
    Although this value isn't strictly required, we assume it exists in the spec11 report.
    
    Also changed the name of the contact email from "email" to "consoleUserEmail"
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=235734200
Commits on Feb 25, 2019
  1. Upload task results to GCS

    guyben13 authored and jianglai committed Feb 19, 2019
    This uploads all the report files to GCS, and also creates a cover page that
    summarises all the task states.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=234601015
Commits on Feb 13, 2019
  1. Only inject @Parameter-created variables in the Action itself

    guyben13 authored and jianglai committed Feb 12, 2019
    Icann reports have 3 parameter-provided injections:
    
    - yearMonth
    - subdir
    - reportType
    
    We move all of them away from the "inner classes" and only @Inject them in the Actions themselves.
    
    This has 2 benefits:
    - it's much clearer what all the parameter inputs of the Actions are
    - the "inner injected classes" don't assume anything about the Action that uses them - they will work just as well for JSON actions as for "regular" actions.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=233625765
  2. Set up the plugin build environment

    guyben13 authored and jianglai committed Feb 12, 2019
    The goal of this CL is to set up the build environment to allow plugins to work.
    
    We have a trivial plugin that doesn't do anything (yet) - it just sets itself as the finalizer of all Reporting tasks.
    
    Eventually, this plugin will upload all reports to GCS, and even create a "cover page" linking to each one of them.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=233617499
Commits on Feb 6, 2019
  1. Move LocalDate injection to the Actions themselves

    guyben13 authored and jianglai committed Feb 5, 2019
    We want to make it clear what query (or POST) inputs the user needs to / can give for each Action. That means moving all the @injects of these parameters to the Actions themselves instead of injecting them in "hidden" indirect dependencies.
    
    This has the extra benefit of allowing these indirect dependencies to work for JSON Actions as well, since the "regular" way we @Inject parameters can corrupt the POST JSON data.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=232540758
Commits on Feb 1, 2019
  1. Prevent spellchecking from textarea fields

    guyben13 authored and CydeWeys committed Feb 1, 2019
    The spellchecking causes test flakiness.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=231984097
Commits on Jan 28, 2019
  1. Fix RDE reducer broken in []

    guyben13 authored and CydeWeys committed Jan 25, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=230945703
Commits on Jan 18, 2019
  1. Add web console for creating registrars

    guyben13 authored and jianglai committed Jan 17, 2019
    This console is only to be used by Admins (either GAE admins for this project, or Support accounts). It is for "internal" use only, not for use by the registrars themselves.
    
    To prevent abuse, the registrar is created in a non-functional PENDING state and can only be made functional from the nomulus shell tool.
    
    While in "PENDING" state, the registrar can be updated from the registrar-console by admins.
    
    Also - moving all the web consoles to the same directory (moving the otesetup/* files into registrar/)
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229681011
  2. Remove TLD @parameter from inside the DnsMetrics

    guyben13 authored and jianglai committed Jan 16, 2019
    Currently, the TLD is a "hidden" part of the metric - we record it, but by looking at the call site you can't see that we record it.
    
    Also, it's injected from the query / POST parameter, so we might not even be aware of what the value is and it might not be the value we wanted.
    
    Instead, making it explicit in the Metric call. That way it's also more similar to the "logging" statements that record the same data but have to explicitly output the TLD.
    
    It also makes the tests better, as we test that we indeed record the correct TLD
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229550115
  3. Remove @parameter from RdeStagingReducer

    guyben13 authored and jianglai committed Jan 15, 2019
    The "lenient" bit must be the same between RdeStagingMapper and
    RdeStagingReducer, but this is hidden by the Reducer receiving the bit in a
    completely different way than the mapper.
    
    There are 2 ways to do this:
    - add a "setLenient" function to RdeStagingReducer that we MUST call, or else
      get a runtime error. This is the simplest solution
    - have a RdeStagingReducerBuilder you can inject, and that requires the
      "lenient" value to actually build the RdeStagingReducer. This prevents bugs
      at compile-time but is "more complicated"
    
    I'm going with the second one here, but feel free to ask for the first one.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229423590
  4. Fix Kokoro build broken by []

    guyben13 authored and jianglai committed Jan 15, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229391946
Commits on Jan 17, 2019
  1. Add the App Engine service used in the Action definition

    guyben13 authored and jianglai committed Jan 15, 2019
    Our goal is to be able to address every Action by looking at the class itself, and to make it clearer at a glance what you need to access the Action's endpoint
    
    Currently, we can know from the @action annotation:
    - the endpoint path
    - the Method needed
    - the authentication level needed
    
    This CL adds the service where the Action is hosted, which also translates to the URL.
    
    NOTE - currently we don't have any Action hosted on multiple services. I don't think we will ever need it (since they do the same thing no matter which service they are on, so why host it twice?), but if we do we'll have to update the code to allow it.
    
    The next step after this is to make sure all the @parameters are defined on the Action itself, and then we will be able to craft access to the endpoint programatically (or at least verify at run-time we crafted a correct URL)
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=229375735
Commits on Jan 14, 2019
  1. Clean up streams in SetNumInstancesCommand

    guyben13 authored and CydeWeys committed Jan 11, 2019
    Also using Service instead of serviceId String - because it helps readability.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228952033
Commits on Jan 11, 2019
  1. Clarify optional vs. required fields

    guyben13 authored and CydeWeys committed Jan 11, 2019
    Added a separator between the fields, and marked required fields as "required", so you can't submit without them
    
    Also - changed from base64 to base58 in for the auto-generated password. It's conceivable that someone might need to read it outloud to someone else - and not having "visually similar" characters (like O and 0) can be helpful.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228810158
  2. Set short redemption/add/delete periods for all OT&E TLDs

    guyben13 authored and CydeWeys committed Jan 10, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228791942
Commits on Jan 10, 2019
  1. Fix @VisibleForTesting given the newly deployed enforcement

    guyben13 authored and CydeWeys committed Jan 10, 2019
    Generated code is now also covered by @VisibleForTesting, including Dagger @Inject
    
    This CL is a cleanup of auto-generated code by ghm@ from the Error Prone team
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228748874
  2. Reverse dependency between /flows/ and /batch/

    guyben13 authored and CydeWeys committed Jan 10, 2019
    Certain flows need to launch batched jobs. Logically this would mean that flows
    depend on batch.
    
    However, the current state of dependency was the other way around, and the
    reason for that was ResourceFlowUtils.java that had in it some utility
    functions that weren't used in the flows and were needed in the batch jobs.
    
    This CL removes these utility functions from the /flows/ directory, letting us
    reverse the dependency edge between flows/ and batch/
    
    Part of this was moving the flows/async/ code into batch/ - which also makes sense because flows/async/ just "enqueued" tasks that would then be run by actions in batch/
    
    It makes sense that the code that enqueues the tasks and the code that dequeues the tasks sit in the same library.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=228698761
Commits on Jan 8, 2019
  1. Allow query parameters in the connection's endpoint

    guyben13 authored and CydeWeys committed Jan 4, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=227898246
  2. Tweak the registrar-ote-setup web console

    guyben13 authored and CydeWeys committed Jan 3, 2019
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=227736173
Older
You can’t perform that action at this time.