Permalink
Switch branches/tags
Nothing to show
Commits on Nov 16, 2018
  1. Remove proxy's dependency on config

    jianglai committed Nov 15, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=221666668
Commits on Nov 14, 2018
  1. Move YamlUtils to be under google.registry.util package

    jianglai committed Nov 14, 2018
    This makes it simpler to package google.registry.util as a separate project in
    Gradle that can be depended upon by the proxy package. Currently the proxy
    package depends on both google.registry.util and google.registry.config.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=221450085
  2. Replace iteration over depsets with an explicit .to_list() call

    jianglai committed Nov 13, 2018
    The old pattern did an implicit iteration over a depset which will be forbidden in the future since it is potentially expensive. The new to_list() call is still expensive but it will be more visible.
    
    LSC: []
    Tested:
        TAP --sample for global presubmit queue
        []
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=221266626
Commits on Nov 12, 2018
  1. Do not create a logger during initialization in CidrAddressBlock

    jianglai committed Nov 2, 2018
    This is patched from [] We should have done this when we migrated to
    Flogger.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=219860046
Commits on Nov 2, 2018
  1. Fix FOSS build

    jianglai authored and mindhog committed Nov 2, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=219794867
Commits on Oct 29, 2018
  1. Add javax.activation as a dependency of jaxb

    jianglai committed Oct 27, 2018
    In Java 9+, this module is no longer loaded by default. JAXB needs it to compile.
    
    Also changed the root project name to "nomulus".
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=219000053
Commits on Oct 25, 2018
  1. Update .gitignore for gradle related files

    jianglai committed Oct 25, 2018
    Ignore all gradle build artifacts.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218693364
  2. Explicitly state which Gradle version is tested.

    jianglai committed Oct 25, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218687425
  3. Allow admin to set AllowedTlds in RegistrarSettingsAction

    jianglai committed Oct 24, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218508076
  4. Refactor TmchCertificateAuthority

    jianglai committed Oct 23, 2018
    The main goal of this CL is to make the clock constructor injectable (so that tests do not need to use InjectRule to override the clock). The complication is that the clock is used by two static caches (ROOT_CACHE directly and CRL_CACHE indirectly). The clock is not actually used to construct the lock, but rather to verify that the root certificate is within its validity period.
    
    For ROOT_CACHE we move the verification to its call sites. This adds a bit overhead because the validity check happens every time the cache is called, not just when the cache is built or refreshed. However this check is rather cheap.  Also the resources are included in the jar and the cache is valid for 1 year. Given that we deploy every week, there's not much point making it an expiring cache rather than a static map.
    
    For CRL_CACHE we change the key to a tuple of TmchCaMode and X509Certificate. The certificate is no longer provided from the ROOT_CACHE directly and must be verified before it is provided as a cache key. We left the CRL verification inside the cache loader because it (signature verification) is more expensive compared to simple expiration check, and we do not want to do this every time the cache is called.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218385684
Commits on Oct 22, 2018
  1. Explicitly set the shard size when saving the claims list

    jianglai committed Oct 22, 2018
    This allows us to get rid of the use of InjectRule in tests.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218221409
  2. Do not monitor gradle temp files changes

    jianglai committed Oct 22, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218213950
  3. Test AsyncFlowMetrics without mock

    jianglai committed Oct 22, 2018
    Instead of verifying interactions on the mocks, we instead assert on the real test subject directly.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=218209556
  4. Refactor StringGenerator bindings

    jianglai committed Oct 19, 2018
    Make every dependency request explicit on what encoding is used. Also get rid of InjectRule in XjcToDomainResourceConverterTest.
    
    Random number generator providers are separated to secure and insecure ones. The insecure ones must be explicitly requested (usually for use cases where security is not of concern, for better speed).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217921422
  5. Refactor LordnTask to LordnTaskUtils

    jianglai committed Oct 18, 2018
    Made it clear that it is a util class and moved some of the functions only used in NordnUploadAction (to NordnUploadAction). Also used Retrier to handle retries when leasing tasks.
    
    These changes allow us to no longer use InjectRule in related unit tests.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217761117
  6. Remove InjectRule in UrlFetchUtilsTest

    jianglai committed Oct 18, 2018
    It should have been removed in []
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217728371
  7. Remove the use of InjectRule in IdnLabelValidatorTest

    jianglai committed Oct 18, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217707263
  8. Fix FOSS build

    jianglai committed Oct 17, 2018
    com.google.common.base.Randoms.insecureRandom is not open sourced.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217598084
  9. Do not use InjectRule to mock stdin in ExecuteEppCommandTest

    jianglai committed Oct 17, 2018
    Use System.setIn() to do the same thing.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217595385
  10. Remove the use of InjectRule in UrlFetchUtilsTest

    jianglai committed Oct 17, 2018
    Random used to be a static variable which requires InjectRule to mock it in unit tests. It is now a singleton, which ensures that the same instance is called every time and Random.nextBytes() generates results that distribute uniformly between each call.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217592767
  11. Change SendEmailService to an instance field.

    jianglai committed Oct 17, 2018
    This allows us to inject it with Dagger and avoid using InjectRule to set it
    in unit tests.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217571475
Commits on Oct 17, 2018
  1. Fix EPP quota handling bug

    jianglai authored and CydeWeys committed Oct 15, 2018
    We limit the maximum number of concurrent connections that a client can make the proxy. The quota is implemented as a (thread-safe) map of client certificate hash to available number of connections. When a new connection is made, we decrement the availability counter by one. When the counter hits zero, no more connections can be made and any new connection from the same client is terminated by the proxy.
    
    Currently, the counter is incremented when a connection is terminated, including connections that are terminated *because* the quota is reached (i. e. the connections for which the counter is not decremented because the counter is already zero). This means that the first time the quota is reached, the next connection is dropped, the counter is incremented to 1 and new connections can be made again, bypassing the quota. This process can be repeated to achieve, theoretically, infinite quota.
    
    This CL fixes this bug by only incrementing the counter, upon connection termination, for connections that have decremented the counter in the first place.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217231593
  2. Update terraform version constraint

    jianglai authored and CydeWeys committed Oct 15, 2018
    There is no "google_project" resource managed by terraform, so we are not worried about the new terraform binary destroying/re-creating GAE resources.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217206226
  3. Update Spec 11 emails body and add a bcc address.

    jianglai authored and CydeWeys committed Oct 15, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=217150650
Commits on Oct 8, 2018
  1. Explicitly set terraform version in preparation for the incoming 1.13…

    jianglai authored and CydeWeys committed Oct 4, 2018
    ….0 update
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=215806094
  2. Update apache sshd version

    jianglai authored and CydeWeys committed Oct 4, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=215783691
  3. Do not include transactions with zero unit price in invoice

    jianglai authored and CydeWeys committed Oct 3, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=215611195
  4. Update bazel version to 0.17.2

    jianglai authored and CydeWeys committed Oct 3, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=215603517
Commits on Sep 20, 2018
  1. Move GCP proxy code to the old [] proxy's location

    jianglai authored and CydeWeys committed Sep 19, 2018
    1. Moved code for the GCP proxy to where the [] proxy code used to live.
    3. Corrected reference to the GCP proxy location.
    4. Misc changes to make ErrorProne and various tools happy.
    
    +diekmann to LGTM terraform whitelist change.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=213630560
  2. Do not send SNI headers in the GCP proxy

    jianglai authored and CydeWeys committed Sep 17, 2018
    The server no longer checks it as of []
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=213278568
  3. Update to bazel 0.17.1

    jianglai authored and CydeWeys committed Sep 17, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=213271889
Commits on Sep 15, 2018
  1. Remove checking of SNI headers

    jianglai committed Sep 14, 2018
    This is only useful when we used the [] proxy because the GFE requires SNI during handshake in order to request the client certificate. The GCP proxy does not need this (it always requests the client certificate). We do not need to check for its existence.
    
    Also removed the checking of internal headers for ssl cert hash used only by the [] proxy.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=213059027
  2. Update dependencies to satisfy strictness and remove -jpl_strict_deps…

    jianglai committed Sep 14, 2018
    … feature
    
    Tested:
        TAP --sample for global presubmit queue
        []
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=213040447
Commits on Sep 14, 2018
  1. Change how access tokens are refreshed

    jianglai authored and CydeWeys committed Sep 13, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=212880971
Commits on Sep 8, 2018
  1. Update max pod number to 10

    jianglai committed Aug 23, 2018
    This should not cause any waste as the pods are only scaled up when necessary.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=209881536