Permalink
Switch branches/tags
Nothing to show
Commits on Nov 12, 2018
  1. Don't use gradlew from travis

    mindhog authored and jianglai committed Nov 8, 2018
    Since we're explicitly downloading a version of travis anyway, just run that
    and don't bother with creating gradlew which does nothing but download the
    same version over again.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=220618139
Commits on Nov 2, 2018
  1. Add a .travis.yml file

    mindhog committed Nov 1, 2018
    Add the Travis-CI configuration file, which will allow our Gradle build to be
    tested from Github with travis.
    
    TESTED:
      1) Repeatedly tweaked this on own local fork of google/nomulus until I was able to successfully build.
      2) Verified that this shows up in the tarball after "blaze build :opensource-staging"
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=219678030
Commits on Oct 29, 2018
  1. Do output encapsulation in a try/with

    mindhog authored and jianglai committed Oct 29, 2018
    Move the shell output encapsulation so that we don't double-wrap on a
    premature exit.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=219136896
Commits on Oct 3, 2018
  1. Add dependency on diffutils

    mindhog authored and jianglai committed Sep 27, 2018
    com_google_truth has a dependency on diffutils that we're not exposing.  This
    becomes problematic in cases where certain tests fail and the equality check
    can't show the difference.  If this happens, instead of the original failure
    all we see is a failure to load diffutils.
    
    Note that com_google_truth appears to have some other dependencies that we are
    also not exposing, but that so far these have not been problematic.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=214774587
Commits on Sep 8, 2018
  1. Remove ServerSideCommand

    mindhog authored and jianglai committed Sep 5, 2018
    ServerSideCommand now just aggregates CommandWithConnection and
    CommandWithRemoteApi, so it's arguably clearer for commands to just implement
    both of these.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=211670031
  2. Rename RemoteApiCommand to CommandWithRemoteApi

    mindhog authored and jianglai committed Sep 4, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=211521742
  3. Allow AppEngineConnection to target services other than "tools"

    mindhog authored and jianglai committed Sep 4, 2018
    This change required several things:
    - Separating out the interfaces that merely do HTTP calls to the backend from those
      that require the remote API (only load the remote API for the latter).  Only the
      tools service provides the remote api endpoint.
    - Removing the XSRF token as an authentication mechanism (with OAUTH, we no longer
      need this, and trying to provide it requires initialization of the datastore
      code which requires the remote API)
    
    I can't think of a compelling unit test for this beyond what already exists.
    Tested:
      Verified that:
      - nomulus tool commands (e.g. "list_tlds") work against the tools service as they
        currently do
      - The "curl" command hits endpoints on "tools" by default.
      - We can use --server to specify endpoints on the default service.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=211510454
  4. Uncomment crontab entry for deleteProberData

    mindhog authored and jianglai committed Aug 24, 2018
    This was only supposed to stay commented out until load-testing was complete.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=210087917
  5. Disallow creating CDNS zones for sandbox TLDs

    mindhog authored and jianglai committed Aug 23, 2018
    Do not allow the user to create TLDs on sandbox that aren't of the form
    "*.test.".  If real TLDs are created, they will block users from registering
    names under that TLD for the nameserver set that we're using for sandbox.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=209983482
Commits on Aug 20, 2018
  1. Remove special Cloud DNS configuration from sandbox.

    mindhog authored and jianglai committed Aug 15, 2018
    Removing this stanza from the config will cause sandbox to write to production
    cloud dns, which is what we want.
    
    Likewise, exclude sandbox in addition to production in the create_cdns_tld
    command from the environments that point to staging.
    
    Cloud DNS has 3 environments that we would consider using:
    - staging which is reset every week, so we can't use it for sandbox
    - testing, which is not accessible from external App Engine
    - production
    
    Because of the difficulties with the first two, we've decided to use production.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=208834786
Commits on Aug 10, 2018
  1. Create a nomulus "curl" command

    mindhog authored and jianglai committed Aug 7, 2018
    Create a command to send arbitrary, authenticated HTTP requests to the backend
    and remove the existing commands that are basically just wrappers around this.
    
    Tested:
      In addition to the unit tests, verified both get and post requests against
      alpha.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=207756509
Commits on May 18, 2018
  1. Revert error message escaping to hand written version

    mindhog authored and jianglai committed May 15, 2018
    It turns out that SourceCodeEscapers has still not been released to github.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=196721579
  2. Allow "encapsulated output" from the shell command

    mindhog authored and jianglai committed May 15, 2018
    Since the ConsoleReader now controls the display of the prompt, there is no
    longer any way for an external program interacting with the nomulus shell to
    recognize when the last command issued has been completed.
    
    To remedy this, we introduce an "--encapsulate_output" flag, which causes
    standard output and standard error to be wrapped in a class that precedes
    all normal lines of output with a prefix ("out: " or "err: ", accordingly)
    and allows the command processor to insert a "SUCCESS" or "FAILURE"
    line (with no special prefix) after completing the processing of a
    command.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=196702338
Commits on May 6, 2018
  1. Increase the number of instances on alpha

    mindhog authored and jianglai committed May 1, 2018
    Increase the instances on alpha to achieve parity with sandbox.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=194980588
Commits on Apr 10, 2018
  1. Create prod Cloud DNS domains in prod zonespace

    mindhog authored and CydeWeys committed Apr 3, 2018
    When running create_cdns_tld in "production" mode, specify the Cloud DNS
    production namespace instead of the staging namespace.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=191451390
  2. Remove unused variable from ShellCommandTest

    mindhog authored and CydeWeys committed Apr 2, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=191340225
  3. Inline calls to get command from jcommander

    mindhog authored and CydeWeys committed Apr 2, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=191338771
Commits on Apr 2, 2018
  1. Fix multiple invocations of the "shell" command

    mindhog authored and jianglai committed Apr 2, 2018
    JCommander doesn't seem to reset objects when it populates them with data from
    an argument list during command processing, so recreate the command objects
    every time we do a run().
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=191332392
  2. Remove Registrar caching from all console actions

    mindhog authored and jianglai committed Mar 27, 2018
    Caching turns out to be an anti-pattern for the console.  If we use it, changes from the user just get obliterated by the older, cached version the next time the console refreshes (and it happens to refresh after every update).  Caching is also not very useful here, as the amount of database access driven by the console is very small.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=190650931
  3. Implement "premium price ack required" checkbox

    mindhog authored and jianglai committed Mar 23, 2018
    Implement a checkbox in the "Resources" tab to allow registrars to toggle
    their "premium price ack required" flag.
    
    Tested:
      Verfied the console functionality by hand.  I've started work on an
      automated test, but we can't actually test those from blaze and the
      kokoro tests are way too time-consuming to be practical for development, so
      we're going to have to either find a way to run those locally outside of
      the normal process or make do without a test.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=190212177
Commits on Mar 19, 2018
  1. Add a "shell" pseudo-command to nomulus tool

    mindhog authored and jianglai committed Mar 12, 2018
    Add the "shell" command which lets you run multiple other command in a single
    session, sparing you the initialization costs for all but the first of them.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=188712815
Commits on Jan 19, 2018
  1. Remove JSch threading hack

    mindhog authored and CydeWeys committed Jan 17, 2018
    Remove the hack that allows us to use JSch with Java 7 on App Engine -
    basically, we have a modified version of JSch that lets us attach a
    GAE-friendly thread factory and use that for all JSch threads.
    
    TESTED: Verified that RDE SFTP uploads still work on alpha.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=182208225
Commits on Nov 21, 2017
  1. Increase max number of sandbox frontend instances to 8

    mindhog authored and jianglai committed Nov 10, 2017
    This mirrors production in hopes of triggering b/67508570 to test the fix.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=175295742
Commits on Oct 24, 2017
  1. Translate multi-part TLD zone names

    mindhog authored and jianglai committed Oct 12, 2017
    Convert periods to hyphens in multi-part TLDs when using them as a zone name
    (cloud-dns doesn't allow periods in zone names).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=172007089
Commits on Oct 10, 2017
  1. Use a direct reference to jsch 0.1.53

    mindhog authored and CydeWeys committed Oct 9, 2017
    Use a direct reference to the jsch 0.1.53 package instead of going through the
    target link, which doesn't exist after MOE transformation.  Also change the
    target's visibility (since the whitelist referenced by the current rule isn't
    preserved by the moe transform).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=171554085
  2. Upgrade domain-registry to jsch 0.1.53

    mindhog authored and CydeWeys committed Oct 6, 2017
    TESTED=Verified on Alpha with an updated build using Java 8, Verified on alpha
    against the latest java 8 based build.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=171297613
  3. Add "create_cdns_tld" command to nomulus

    mindhog authored and CydeWeys committed Oct 5, 2017
    Automated g4 rollback of changelist 171011304.  Please see history below, the original CL was []  Rolling back and re-mailing
    so I can get a readability review on it.
    
    *** Reason for rollback ***
    
    Re-opening for readability review.
    
    *** Original change description ***
    
    Automated g4 rollback of changelist 170906329.
    
    *** Reason for rollback ***
    
    Forgot to send this for readability review.
    
    *** Original change description ***
    
    Add "create_cdns_tld" command to nomulus
    
    Add a command to allow us to create the managed zone for a new TLD in cloud
    dns.
    
    Note: this implementation is problematic, it's currently doing its own thing
    as far as credentials and http transport, making it unusable with the []
    channel and the credentials generated by login.  Unfortunately, fixing the plumbing to make it work right is difficult, and we have an immediate need for
    this functionality.
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=171161371
Commits on Oct 4, 2017
  1. Automated g4 rollback of changelist 170906329.

    mindhog authored and CydeWeys committed Oct 4, 2017
    *** Reason for rollback ***
    
    Forgot to send this for readability review.
    
    *** Original change description ***
    
    Add "create_cdns_tld" command to nomulus
    
    Add a command to allow us to create the managed zone for a new TLD in cloud
    dns.
    
    Note: this implementation is problematic, it's currently doing its own thing
    as far as credentials and http transport, making it unusable with the []
    channel and the credentials generated by login.  Unfortunately, fixing the
    plumbing to make it work right is difficult, and we have an immediate need for
    this functionality.
    
    b/67367533 created to clean this up, along with...
    
    ***
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=171011304
  2. Add "create_cdns_tld" command to nomulus

    mindhog authored and CydeWeys committed Oct 3, 2017
    Add a command to allow us to create the managed zone for a new TLD in cloud
    dns.
    
    Note: this implementation is problematic, it's currently doing its own thing
    as far as credentials and http transport, making it unusable with the []
    channel and the credentials generated by login.  Unfortunately, fixing the
    plumbing to make it work right is difficult, and we have an immediate need for
    this functionality.
    
    b/67367533 created to clean this up, along with related warts in the codebase.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=170906329
  3. Add config parameters to point at us to use cloud-dns staging

    mindhog authored and CydeWeys committed Sep 28, 2017
    Add cloudDns.{rootUrl, servicePath} to allow us to point an environment at the
    Cloud DNS staging API for testing.  Make sandbox and alpha point to staging.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=170340859
  4. Build DNS changes with HashMap instead of Builder

    mindhog authored and CydeWeys committed Sep 26, 2017
    The existing CloudDnsWriter code uses ImmutableMap.Builder to construct the
    map of DNS records to update.  This has been seen to fail on alpha, presumably
    in a cases where host records and domain records produce duplicate updates for
    a host.
    
    Convert the Builder to a HashMap, allowing us to safely overwrite existing
    records in the case of duplicates.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=170103421
Commits on Sep 20, 2017
  1. Implement compare_db_backups "main"

    mindhog authored and jianglai committed Sep 13, 2017
    Implement toplevel class that reads in two database backups and displays
    diffs.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=168592124
Commits on Sep 12, 2017
  1. Create an entity record accumulator

    mindhog authored and jianglai committed Sep 1, 2017
    RecordAccumulator builds a set of datastore Entity records from a set of
    leveldb logfiles in a directory tree (which is how we receive them for
    database backup/restore testing).
    
    This CL also refactors some of the logfile test code out of
    LevelDbLogReaderTest so that we can reuse it for building test logs.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=167313553
  2. Implement ComparableEntity class

    mindhog authored and jianglai committed Sep 1, 2017
    ComparableEntity allows us to compare Entity objects by both key and
    properties, regardless of the order of those properties in the protobufs.
    
    This is necessary for comparing database backups, where we evaluate the
    differences in the set of entities in one backup with those of another.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=167288489
Commits on Aug 29, 2017
  1. Remove RdeUploadActionTest from FOSS build

    mindhog authored and CydeWeys committed Aug 17, 2017
    Second attempt at removing this test by simply removing from the generated
    test rules.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=165575517