Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move terraform and kubernetes folder to be under proxy #127

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@jianglai
Copy link
Member

commented Jun 19, 2019

There is no reason for them to be under proxy/src/... any more now that
we have a Gradle-idiomatic folder structure.


This change is Reviewable

@jianglai jianglai requested a review from gbrodman Jun 19, 2019

@googlebot googlebot added the cla: yes label Jun 19, 2019

@@ -103,7 +103,7 @@ $ gcloud auth application-default login
Login with the account that has "Project Owner" role of all three projects
mentioned above.

Navigate to `java/google/registry/proxy/terraform`, create a folder called
Navigate to `proxy/terraform`, create a folder called
`envs`, and inside it, create a folder for the environment that proxy is
deployed to ("alpha" for example). Copy `example_config.tf` to the environment
folder.

This comment has been minimized.

Copy link
@gbrodman

gbrodman Jun 20, 2019

Collaborator

I think we also want to change line 112

# Deploys shared kubernetes objects.
$ kubectl create -f \
java/google/registry/proxy/kubernetes/proxy-service.yaml
proxy/kubernetes/proxy-service.yaml

This comment has been minimized.

Copy link
@gbrodman

gbrodman Jun 20, 2019

Collaborator

I think we also want to change lines 538 and 611

@@ -1,14 +1,5 @@
apply plugin: 'java'

sourceSets {

This comment has been minimized.

Copy link
@gbrodman

gbrodman Jun 20, 2019

Collaborator

wooooo I like removing this

Move terraform and kubernetes folder to be under proxy
There is no reason for them to be under proxy/src/... any more now that
we have a Gradle-idiomatic folder structure.

@jianglai jianglai force-pushed the jianglai:proxy-refactor branch from e35c1e7 to d2b060b Jun 20, 2019

@jianglai jianglai requested a review from gbrodman Jun 20, 2019

@jianglai
Copy link
Member Author

left a comment

Reviewable status: 0 of 30 files reviewed, 2 unresolved discussions (waiting on @gbrodman)


docs/proxy-setup.md, line 109 at r1 (raw file):

Previously, gbrodman wrote…

I think we also want to change line 112

Done.


docs/proxy-setup.md, line 239 at r1 (raw file):

Previously, gbrodman wrote…

I think we also want to change lines 538 and 611

Done.

@gbrodman
Copy link
Collaborator

left a comment

:lgtm:

Reviewed 30 of 30 files at r1.
Reviewable status: 29 of 30 files reviewed, 2 unresolved discussions (waiting on @gbrodman)

@jianglai jianglai requested a review from gbrodman Jun 20, 2019

@gbrodman
Copy link
Collaborator

left a comment

I think that should have counted as an approval before? Odd.

@jianglai jianglai requested a review from gbrodman Jun 20, 2019

@jianglai jianglai merged commit 520145f into google:master Jun 20, 2019

3 of 4 checks passed

code-review/reviewable 1 file, 2 discussions left (gbrodman)
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:proxy-refactor branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.