Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict versions in NPM versioning #132

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
None yet
3 participants
@gbrodman
Copy link
Collaborator

commented Jun 21, 2019

It'll reduce surprise version changes


This change is Reviewable

@googlebot googlebot added the cla: yes label Jun 21, 2019

@gbrodman gbrodman requested a review from jianglai Jun 21, 2019

@jianglai
Copy link
Member

left a comment

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Use strict versions in NPM versioning
It'll reduce surprise version changes

@gbrodman gbrodman force-pushed the gbrodman:strictVersions branch from 45ed69c to 3c3af8d Jun 24, 2019

@gbrodman gbrodman merged commit 16b0c42 into google:master Jun 25, 2019

4 checks passed

cla/google All necessary CLAs are signed
code-review/reviewable 2 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@gbrodman gbrodman deleted the gbrodman:strictVersions branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.