Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add hello.xml file #147

Merged
merged 2 commits into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@jianglai
Copy link
Member

commented Jul 2, 2019

Apparently it was lost during the great refactoring.


This change is Reviewable

@jianglai jianglai requested a review from gbrodman Jul 2, 2019

@googlebot googlebot added the cla: yes label Jul 2, 2019

@gbrodman
Copy link
Collaborator

left a comment

It's actually still there, but in the resources/ subfolder. Can we hold off on this until my refactor of the test resource files goes through?

@jianglai
Copy link
Member Author

left a comment

Oh, I didn't see it. But this file is not for testing, this is actually used in production. I guess when we moved it we put it in the wrong place. This change should be independent of the test resource refactoring.

Reviewable status: 0 of 3 files reviewed, all discussions resolved

@gbrodman
Copy link
Collaborator

left a comment

It was used in production but lived in test? That's super weird

Reviewable status: 0 of 3 files reviewed, all discussions resolved

@jianglai
Copy link
Member Author

left a comment

It is supposed to be used in production. It was moved to test by mistake, but since we have not released a new proxy after the refactor, the problem was not caught immediately.

Reviewable status: 0 of 3 files reviewed, all discussions resolved

Re-add hello.xml file
Apparently it was lost during the great refactoring.

@jianglai jianglai force-pushed the jianglai:hello branch from 3996426 to 9903481 Jul 2, 2019

@jianglai jianglai force-pushed the jianglai:hello branch from 9903481 to 5110236 Jul 2, 2019

@jianglai jianglai merged commit 25ee92b into google:master Jul 2, 2019

3 of 4 checks passed

code-review/reviewable 3 files left
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:hello branch Jul 2, 2019

CydeWeys added a commit to CydeWeys/nomulus that referenced this pull request Jul 19, 2019

Re-add hello.xml file (google#147)
* Re-add hello.xml file

Apparently it was lost during the great refactoring.

* Remove hello.xml from test resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.