Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JS and CSS files to a Javascript source dir #156

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
3 participants
@gbrodman
Copy link
Collaborator

commented Jul 3, 2019

This change is Reviewable

@googlebot googlebot added the cla: yes label Jul 3, 2019

@jianglai
Copy link
Member

left a comment

Reviewed 1 of 42 files at r1.
Reviewable status: 1 of 42 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/ui/conformance_proto.txt, line 6 at r1 (raw file):

Quoted 6 lines of code…
requirement: {
  type: BANNED_PROPERTY_WRITE
  error_message: 'Assignment to Element.prototype.innerHTML is not allowed. '
      'Use goog.dom.safe.setInnerHtml instead. '
  value: 'Element.prototype.innerHTML'
}

Is this relevant to the refactor?

@gbrodman
Copy link
Collaborator Author

left a comment

Reviewable status: 1 of 42 files reviewed, 1 unresolved discussion (waiting on @jianglai)


core/src/main/java/google/registry/ui/conformance_proto.txt, line 6 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…
requirement: {
  type: BANNED_PROPERTY_WRITE
  error_message: 'Assignment to Element.prototype.innerHTML is not allowed. '
      'Use goog.dom.safe.setInnerHtml instead. '
  value: 'Element.prototype.innerHTML'
}

Is this relevant to the refactor?

Not directly, but it should be removed and it was in the same directory (allows us to remove the directory entirely)

@gbrodman gbrodman force-pushed the gbrodman:move-js branch from aef89bb to 41b9bdc Jul 3, 2019

@gbrodman gbrodman force-pushed the gbrodman:move-js branch from 41b9bdc to a6d61db Jul 3, 2019

@jianglai
Copy link
Member

left a comment

Reviewed 41 of 42 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gbrodman gbrodman merged commit e5bafdd into google:master Jul 5, 2019

4 checks passed

cla/google All necessary CLAs are signed
code-review/reviewable 43 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@gbrodman gbrodman deleted the gbrodman:move-js branch Jul 5, 2019

CydeWeys added a commit to CydeWeys/nomulus that referenced this pull request Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.