Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set beam deployment environment in GCB trigger #157

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@jianglai
Copy link
Member

commented Jul 3, 2019

This allows for easier testing.


This change is Reviewable

@jianglai jianglai requested a review from hstonec Jul 3, 2019

@googlebot googlebot added the cla: yes label Jul 3, 2019

@jianglai jianglai force-pushed the jianglai:tool branch from 983a348 to b6ff0df Jul 3, 2019

@hstonec
Copy link
Collaborator

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hstonec and @jianglai)


release/cloudbuild-release.yaml, line 82 at r1 (raw file):

    sed -i s/'$${TAG_NAME}'/${TAG_NAME}/g release/cloudbuild-sync.yaml
    sed -i s/'$${TAG_NAME}'/${TAG_NAME}/g release/cloudbuild-beam.yaml
    sed -i s/'$${_ENV}'/${_ENV}/g release/cloudbuild-beam.yaml

Do we still need this substitution? If I read this correctly, we replace ${_ENV} with ${_ENV}?

@hstonec

hstonec approved these changes Jul 3, 2019

Copy link
Collaborator

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jianglai)


release/cloudbuild-release.yaml, line 82 at r1 (raw file):

Previously, hstonec (Shicong Huang) wrote…

Do we still need this substitution? If I read this correctly, we replace ${_ENV} with ${_ENV}?

Oh, I see, the second ${_ENV} is substituted in cloudbuild-release.yaml.

@hstonec
Copy link
Collaborator

left a comment

:lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jianglai)

@jianglai jianglai requested a review from hstonec Jul 3, 2019

@jianglai
Copy link
Member Author

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hstonec)


release/cloudbuild-release.yaml, line 82 at r1 (raw file):

Previously, hstonec (Shicong Huang) wrote…

Oh, I see, the second ${_ENV} is substituted in cloudbuild-release.yaml.

The point is when cloudbuild-release.yaml runs, it substitutes the "_ENV" in cloudbuild-beam.yaml with the environment that is supplied in the GCB trigger. cloudbuild-beam.yaml is kicked off by Spinnaker which cannot do any variable substitution (yet), so when I test with deployment to alpha I want to set the _ENV to alpha when running cloudbuild-release.yaml, and the resulting cloudbuild-beam.yaml will have that value hardcoded.

@jianglai jianglai merged commit 82f51ac into google:master Jul 3, 2019

3 of 4 checks passed

code-review/reviewable 1 file, 1 discussion left (hstonec)
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:tool branch Jul 3, 2019

CydeWeys added a commit to CydeWeys/nomulus that referenced this pull request Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.