Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependencies' open-source licenses #165

Merged
merged 1 commit into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@weiminyu
Copy link
Collaborator

commented Jul 10, 2019

Use jk1/Gradle-License-Report to verify that all
dependencies have open-source licenses.

Note that the following dependencies are not checked:

Dependencies of official Gradle plugins
Dependencies declared in buildscript block
Dependencies of jk1/Gradle-License-Report itself


This change is Reviewable

Check dependencies' open-source licenses
Use jk1/Gradle-License-Report to verify that all
dependencies have open-source licenses.

Note that the following dependencies are not checked:

Dependencies of official Gradle plugins
Dependencies declared in buildscript block
Dependencies of jk1/Gradle-License-Report itself

@googlebot googlebot added the cla: yes label Jul 10, 2019

@weiminyu
Copy link
Collaborator Author

left a comment

Redoing after accidentally deleted the previous review branch.

Comments addressed from earlier:

  • config directory name using underscore
  • missing newline
  • gradle file indent.

Reviewable status: 0 of 5 files reviewed, all discussions resolved

@weiminyu weiminyu requested review from jianglai, gbrodman and CydeWeys Jul 10, 2019

@@ -71,6 +71,19 @@ reportUploader {

apply from: 'dependencies.gradle'

apply from: 'dependency_license.gradle'

// Custom task to run checkLicense in buildSrc, which is not triggered

This comment has been minimized.

Copy link
@gbrodman

gbrodman Jul 11, 2019

Collaborator

Do we have an issue filed to move the buildSrc into a separate project and get rid of this? If not, could we file one please?

@weiminyu
Copy link
Collaborator Author

left a comment

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @CydeWeys, @gbrodman, and @jianglai)


build.gradle, line 76 at r1 (raw file):

Previously, gbrodman wrote…

Do we have an issue filed to move the buildSrc into a separate project and get rid of this? If not, could we file one please?

We can use Lai's resultstore bug: b//137111374

@gbrodman
Copy link
Collaborator

left a comment

sweet thanks

@weiminyu weiminyu merged commit 29e4d8d into google:master Jul 11, 2019

3 of 4 checks passed

code-review/reviewable 5 files, 1 discussion left (CydeWeys, gbrodman, jianglai)
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@weiminyu weiminyu deleted the weiminyu:jk1-license-report branch Jul 11, 2019

CydeWeys added a commit to CydeWeys/nomulus that referenced this pull request Jul 19, 2019

Check dependencies' open-source licenses (google#165)
* Check dependencies' open-source licenses

Use jk1/Gradle-License-Report to verify that all
dependencies have open-source licenses.

Note that the following dependencies are not checked:

Dependencies of official Gradle plugins
Dependencies declared in buildscript block
Dependencies of jk1/Gradle-License-Report itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.