Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customized .lgtm.yml #191

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@jianglai
Copy link
Member

commented Jul 23, 2019

This change is Reviewable

@jianglai jianglai added the WIP label Jul 23, 2019

@googlebot googlebot added the cla: yes label Jul 23, 2019

@jianglai jianglai removed the WIP label Jul 23, 2019

@jianglai jianglai requested a review from gbrodman Jul 23, 2019

@jianglai jianglai force-pushed the jianglai:lgtm branch from 894f57d to 8881827 Jul 23, 2019

@jianglai jianglai force-pushed the jianglai:lgtm branch from 8881827 to 7abb1b1 Jul 23, 2019

@gbrodman

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

Do we have a doc on what LGTM does, out of curiosity?

@jianglai
Copy link
Member Author

left a comment

We probably should. But for now I just want to enable it so that we can see exactly what analysis results it is giving.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @gbrodman)

@gbrodman
Copy link
Collaborator

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @jianglai)


.lgtm.yml, line 4 at r1 (raw file):

  java:
    prepare:
      packages: "npm"

Why npm, out of curiosity?

@jianglai jianglai requested a review from gbrodman Jul 23, 2019

@jianglai
Copy link
Member Author

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


.lgtm.yml, line 4 at r1 (raw file):

Previously, gbrodman wrote…

Why npm, out of curiosity?

Cause it mostly worked out of the box, but the default image doesn't have npm, so we'd have to install that package.

@gbrodman
Copy link
Collaborator

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @jianglai)


.lgtm.yml, line 4 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…

Cause it mostly worked out of the box, but the default image doesn't have npm, so we'd have to install that package.

Does LGTM actually run our code / builds? I don't know much about it. So this step would basically tell it to install NPM before analyzing Java code?

@jianglai jianglai requested a review from gbrodman Jul 23, 2019

@jianglai
Copy link
Member Author

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


.lgtm.yml, line 4 at r1 (raw file):

Previously, gbrodman wrote…

Does LGTM actually run our code / builds? I don't know much about it. So this step would basically tell it to install NPM before analyzing Java code?

Correct. It actually builds the code. And yes it tells it to install npm before buliding.

@gbrodman
Copy link
Collaborator

left a comment

:lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman)

@jianglai jianglai merged commit b452b06 into google:master Jul 23, 2019

5 of 6 checks passed

code-review/reviewable 1 file, 1 discussion left (gbrodman)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:lgtm branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.