Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dependency_license.gradle file #196

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@jianglai
Copy link
Member

commented Jul 24, 2019

The file name confused the licensee app
(https://github.com/licensee/licensee) that GitHub uses to detect
license files. It thinks this file is also a license file and was not
able to determine is type.


This change is Reviewable

@jianglai jianglai requested a review from weiminyu Jul 24, 2019

@googlebot googlebot added the cla: yes label Jul 24, 2019

@jianglai jianglai requested a review from gbrodman Jul 25, 2019

@gbrodman

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

What if we made it dependency_license_report.gradle instead? Is that too long? Naming is tough.

@jianglai jianglai force-pushed the jianglai:license branch from 48ee30c to a1fe86e Jul 26, 2019

Rename dependency_license.gradle file
The file name confused the licensee app
(https://github.com/licensee/licensee) that GitHub uses to detect
license files. It thinks this file is also a license file and was not
able to determine is type.

@jianglai jianglai force-pushed the jianglai:license branch from a1fe86e to e2d5580 Jul 26, 2019

@jianglai
Copy link
Member Author

left a comment

Tested and it didn't work... :(

$ licensee detect .
License:        NOASSERTION
Matched files:  LICENSE, dependency_license_report.gradle, package.json                                           
LICENSE:
  Content hash:  ab3901051663cb8ee5dea9ebdff406ad136910e3                                                         
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       Apache-2.0
dependency_license_report.gradle:
  Content hash:  1ecf3d663732ebda15aa9c2f909b7f4d48c7304a                                                         
  License:       NOASSERTION
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     Apache-2.0

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @gbrodman and @weiminyu)

@gbrodman
Copy link
Collaborator

left a comment

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @gbrodman and @weiminyu)

@jianglai jianglai merged commit 2ae5aba into google:master Jul 26, 2019

4 of 7 checks passed

code-review/reviewable 3 files left (gbrodman, weiminyu)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:license branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.