Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenJDK8 for Gradle build #210

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@hstonec
Copy link
Collaborator

commented Aug 2, 2019

This change is Reviewable

@googlebot googlebot added the cla: yes label Aug 2, 2019

@hstonec hstonec added the WIP label Aug 2, 2019

@jianglai
Copy link
Member

left a comment

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hstonec)


gradle.properties, line 8 at r1 (raw file):

flowDocsFile=
enableDependencyLocking=true
org.gradle.java.home=/usr/lib/jvm/java-8-openjdk-amd64

Can you add a TODO to remove this once Google java 8 is fixed. It is not a good idea to hardcord a path like this.

@hstonec hstonec force-pushed the hstonec:fix-missing-imageio branch from 43f86d6 to df53fb9 Aug 2, 2019

@hstonec hstonec removed the WIP label Aug 2, 2019

@hstonec hstonec changed the title use OpenJDK8 for Gradle build Use OpenJDK8 for Gradle build Aug 2, 2019

@hstonec
Copy link
Collaborator Author

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jianglai)


gradle.properties, line 8 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…

Can you add a TODO to remove this once Google java 8 is fixed. It is not a good idea to hardcord a path like this.

Done. Maybe we should consider to use openjdk8 in the future to avoid issue like this, but I agree we should get rid of this hardcode path.

@hstonec hstonec merged commit 8e00f85 into google:master Aug 2, 2019

3 of 7 checks passed

code-review/reviewable 1 file, 1 discussion left (jianglai)
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@hstonec hstonec deleted the hstonec:fix-missing-imageio branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.