Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Gradle task to deploy the proxy #214

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@jianglai
Copy link
Member

commented Aug 5, 2019

Also refactored some common code regarding the mapping between
environments and projects.

The script to update proxy deployments and kill all pods are lifted from
https://cs.corp.google.com/piper///depot/google3/domain/registry/tools/bashrc?l=163


This change is Reviewable

@jianglai jianglai requested a review from gbrodman Aug 5, 2019

@googlebot googlebot added the cla: yes label Aug 5, 2019

@jianglai jianglai force-pushed the jianglai:proxy-deploy branch 2 times, most recently from d519b61 to 7afa394 Aug 5, 2019

@@ -18,6 +18,20 @@ task buildProxyImage(dependsOn: deployJar, type: Exec) {
commandLine 'docker', 'build', '-t', 'proxy', '.'
}

task deployProxy(dependsOn: [buildProxyImage, ':verifyDeployment']) {
doLast {

This comment has been minimized.

Copy link
@gbrodman

gbrodman Aug 6, 2019

Collaborator

Is there any way to put these in to a single exec() command? Would that be the correct call?

@gbrodman
Copy link
Collaborator

left a comment

:lgtm:

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @jianglai)

@jianglai jianglai requested a review from gbrodman Aug 6, 2019

@jianglai
Copy link
Member Author

left a comment

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


proxy/build.gradle, line 22 at r1 (raw file):

Previously, gbrodman wrote…

Is there any way to put these in to a single exec() command? Would that be the correct call?

I tried that first. As it turned out a commandLine is just a setter. If you have multiple of them, the last one wins. See:

https://stackoverflow.com/questions/35561014/gradle-execute-multiple-commands-from-task

Add a Gradle task to deploy the proxy
Also refactored some common code regarding the mapping between
environments and projects.

The script to update proxy deployments and kill all pods are lifted from
https://cs.corp.google.com/piper///depot/google3/domain/registry/tools/bashrc?l=163

@jianglai jianglai force-pushed the jianglai:proxy-deploy branch from 7afa394 to 624ecf0 Aug 6, 2019

@jianglai jianglai merged commit 4fd32c8 into google:master Aug 6, 2019

4 of 7 checks passed

code-review/reviewable 5 files left (gbrodman)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:proxy-deploy branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.