Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle wrapper to 5.6 #232

Merged
merged 3 commits into from Aug 24, 2019

Conversation

@jianglai
Copy link
Member

commented Aug 17, 2019

This change is Reviewable

@gbrodman

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2019

It seems like there are some issues with the Gradle upgrade and the shadow jar plugin that we use to build the Nomulus tool.

@jianglai jianglai force-pushed the jianglai:gradle-version branch from 1aa98f7 to 6b318fd Aug 23, 2019

@jianglai

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

This is due to johnrengelman/shadow#508. I'll push an update soon.

@@ -1,3 +1,4 @@
org.gradle.jvmargs=-Xmx1024m

This comment has been minimized.

Copy link
@gbrodman

gbrodman Aug 24, 2019

Collaborator

Isn't this the default? Is specifying it necessary?

This comment has been minimized.

Copy link
@jianglai

jianglai Aug 24, 2019

Author Member

Somehow it was giving me OOM error when I didn't specify this...

This comment has been minimized.

Copy link
@gbrodman

gbrodman Aug 24, 2019

Collaborator

I was apparently wrong, or the posts online I found were wrong. Default is 512 MB apparently

https://docs.gradle.org/current/userguide/build_environment.html#sec:configuring_jvm_memory

@jianglai jianglai merged commit bf52a78 into google:master Aug 24, 2019

4 of 6 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:gradle-version branch Aug 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.