Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proxy deployment script description #245

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@jianglai
Copy link
Member

commented Aug 28, 2019

This change is Reviewable

@jianglai jianglai requested a review from gbrodman Aug 28, 2019

@gbrodman
Copy link
Collaborator

left a comment

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @jianglai)


proxy/deploy-proxy-for-env.sh, line 17 at r1 (raw file):

#
# This script prepares the proxy k8s manifest, pushes it to the clusters, and
# kills all running pods to force k8s to create new pods using the just pushed

super-nit: can we have a dash between 'just' and 'pushed'? I think "just-pushed" is more correct.

@jianglai

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @jianglai)

proxy/deploy-proxy-for-env.sh, line 17 at r1 (raw file):

#
# This script prepares the proxy k8s manifest, pushes it to the clusters, and
# kills all running pods to force k8s to create new pods using the just pushed

super-nit: can we have a dash between 'just' and 'pushed'? I think "just-pushed" is more correct.

Done.

@jianglai jianglai force-pushed the jianglai:proxy-deploy branch from c3150cd to e7dd524 Aug 28, 2019

@jianglai jianglai merged commit dd4300f into google:master Aug 28, 2019

3 of 7 checks passed

code-review/reviewable 1 file, 1 discussion left (jianglai)
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details

@jianglai jianglai deleted the jianglai:proxy-deploy branch Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.