Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate schema using tools command #269

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@weiminyu
Copy link
Collaborator

commented Sep 12, 2019

Rerun GenerateSqlSchemaCommand to pick up RegistryLock
and naming strategy change.

Also updated a new license term which seems to just pop up.


This change is Reviewable

Rerun GenerateSqlSchemaCommand to pick up RegistryLock
and naming strategy change.

Also updated a new license term which seems to just pop up.
@googlebot googlebot added the cla: yes label Sep 12, 2019
@weiminyu weiminyu requested review from mindhog and gbrodman Sep 12, 2019
Copy link
Collaborator Author

left a comment

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @mindhog)


config/dependency-license/allowed_licenses.json, line 118 at r1 (raw file):

Previously, gbrodman wrote…

Was this not already in there? Odd.

This is from org.eclipse.jgit:org.eclipse.jgit. This dependency is not locked,I believe it is because this is a dependency
that is only used by Gradle internals (including official plugins).

@weiminyu weiminyu requested a review from gbrodman Sep 12, 2019
@weiminyu weiminyu merged commit 40a6b78 into google:master Sep 12, 2019
4 of 7 checks passed
4 of 7 checks passed
code-review/reviewable 2 files, 1 discussion left (gbrodman, mindhog)
Details
LGTM analysis: Java No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:generate-registry-lock-schema branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.