Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency-locking config #276

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@weiminyu
Copy link
Collaborator

commented Sep 18, 2019

Reenable dependency locking after a bug errorneouly turned it off.

Removed the guava-related workaround that forcefully resolves to
the -jre distribution.

Enabled locking for buildSrc by updating its property file.

Updated all lock files.


This change is Reviewable

Reenable dependency locking after a bug errorneouly turned it off.

Removed the guava-related workaround that forcefully resolve to
the -jre distribution.

Enabled locking for buildSrc by updating its property file.

Updated all lock files.
@googlebot googlebot added the cla: yes label Sep 18, 2019
@weiminyu weiminyu requested a review from mindhog Sep 19, 2019
Copy link
Member

left a comment

Reviewed 3 of 166 files at r1.
Reviewable status: 3 of 166 files reviewed, all discussions resolved (waiting on @mindhog)

@weiminyu weiminyu merged commit 8123c53 into google:master Sep 19, 2019
4 of 7 checks passed
4 of 7 checks passed
code-review/reviewable 163 files left (mindhog)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:dependency-lock branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.