Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Truth 1.0 #281

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@weiminyu
Copy link
Collaborator

commented Sep 23, 2019

Refactored fail(...) to assertWithMessage(...).fail().

Upgraded com.google.monitoring-client family of dependencies to 1.0.6

Also fixed bad use of io.StringIO (on binary buffer) recently introduced to
google-java-format-diff.py.


This change is Reviewable

Refactored fail(...) to assertWithMessage().fail().

Upgraded com.google.monitoring-client family of dependencies to 1.0.6

Also fixed bad use of io.StringIO (on binary buffer) recently introduced to
google-java-format-diff.py.
@googlebot googlebot added the cla: yes label Sep 23, 2019
@weiminyu weiminyu requested a review from mindhog Sep 23, 2019
Copy link
Member

left a comment

Reviewable status: 0 of 97 files reviewed, 1 unresolved discussion (waiting on @mindhog and @weiminyu)


java-format/google-java-format-diff.py, line 121 at r1 (raw file):

      with open(filename) as f:
        code = f.readlines()
      formatted_code = io.BytesIO(stdout).readlines()

What's up with this change?

Copy link
Member

left a comment

:lgtm:

Reviewable status: 0 of 97 files reviewed, 1 unresolved discussion (waiting on @mindhog and @weiminyu)

@weiminyu weiminyu merged commit b0c1304 into google:master Sep 24, 2019
5 of 7 checks passed
5 of 7 checks passed
code-review/reviewable 97 files, 1 discussion left (mindhog, weiminyu)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:truth branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.