Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socket factory as runtime dependency #286

Merged

Conversation

@hstonec
Copy link
Collaborator

commented Sep 27, 2019

We will use Cloud SQL Socket Factory for nomulus tool to connect to Cloud SQL.


This change is Reviewable

@googlebot googlebot added the cla: yes label Sep 27, 2019
@hstonec hstonec requested a review from weiminyu Sep 27, 2019
Copy link
Collaborator

left a comment

Reviewed 1 of 31 files at r1.
Reviewable status: 1 of 31 files reviewed, all discussions resolved (waiting on @weiminyu)

@hstonec hstonec merged commit 9c7872d into google:master Sep 27, 2019
4 of 7 checks passed
4 of 7 checks passed
code-review/reviewable 30 files left (weiminyu)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@hstonec hstonec deleted the hstonec:add-socket-factory-as-runtime-dependency branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.