Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base64-encoded SQL credentials #314

Merged
merged 1 commit into from Oct 18, 2019
Merged

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Oct 17, 2019

Encode Cloud SQL credential files on gcs with base64,
to be consistent with our Cloud Build practices.

Also renamed a property that specifies where to publish
the schema jar. New name is schema_publish_repo.

Manually tested relevant Flyway tasks.


This change is Reviewable

Encode Cloud SQL credential files on gcs with base64,
to be consistent with our Cloud Build practices.

Also renamed a property that specifies where to publish
the schema jar. New name is schema_publish_repo.
@googlebot googlebot added the cla: yes label Oct 17, 2019
@weiminyu weiminyu requested a review from mindhog Oct 17, 2019
Copy link
Member

mindhog left a comment

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@weiminyu weiminyu merged commit 13dc758 into google:master Oct 18, 2019
7 checks passed
7 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
code-review/reviewable 2 files reviewed
Details
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:base64-cred branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.