Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move soyutils_usegoog.js out of node_modules #342

Merged
merged 3 commits into from Nov 4, 2019
Merged

Conversation

@jianglai
Copy link
Member

jianglai commented Nov 1, 2019

Every time the npmInstall runs, it removes this file from node_modules.
Move it outside the folder to prevent this from happening.

Also moves the karma config file out of the root directory.


This change is Reviewable

Everytime the npmInstall runs, it removes this file from node_modules.
Move it outside the folder to prevent this from happening.
@jianglai jianglai requested a review from gbrodman Nov 1, 2019
@googlebot googlebot added the cla: yes label Nov 1, 2019
Copy link
Collaborator

gbrodman left a comment

Might it be advisable to move this to somewhere inside core/src/main/javascript/?

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @gbrodman)

@jianglai jianglai force-pushed the jianglai:soy branch from a3a37bd to c5eb311 Nov 1, 2019
Copy link
Member Author

jianglai left a comment

Done

Reviewable status: 0 of 5 files reviewed, all discussions resolved

Copy link
Collaborator

gbrodman left a comment

Out of curiosity, why more the Karma configuration file?

Reviewable status: 0 of 5 files reviewed, all discussions resolved

@jianglai

This comment has been minimized.

Copy link
Member Author

jianglai commented Nov 3, 2019

Out of curiosity, why more the Karma configuration file?

Reviewable status: 0 of 5 files reviewed, all discussions resolved

I just thought that we'd want to move all js files out of the root directory.

Copy link
Collaborator

gbrodman left a comment

Because the Karma config file is more of a testing configuration than actual source code I think we want to keep it in the root folder.

Reviewable status: 0 of 5 files reviewed, all discussions resolved

@jianglai

This comment has been minimized.

Copy link
Member Author

jianglai commented Nov 4, 2019

Because the Karma config file is more of a testing configuration than actual source code I think we want to keep it in the root folder.

Reviewable status: 0 of 5 files reviewed, all discussions resolved

Would it be better if it is in core/src/test/? It should definitely inside core because all Karma tests are in core, right?

Copy link
Collaborator

gbrodman left a comment

synced up offline -- let's put it in core/

Reviewable status: 0 of 5 files reviewed, all discussions resolved

Copy link
Member Author

jianglai left a comment

Done

Reviewable status: 0 of 5 files reviewed, all discussions resolved

Copy link
Collaborator

gbrodman left a comment

:lgtm:

Reviewable status: 0 of 5 files reviewed, all discussions resolved

@jianglai jianglai merged commit c472112 into google:master Nov 4, 2019
6 of 7 checks passed
6 of 7 checks passed
code-review/reviewable 5 files left
Details
LGTM analysis: Java No new or fixed alerts
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
LGTM analysis: Python No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@jianglai jianglai deleted the jianglai:soy branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.