Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 6.0 #364

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@jianglai
Copy link
Member

jianglai commented Nov 13, 2019

Several plugins and dependencies are also upgraded to be compatible with Gradle 6.0.

The new nebula lint plugin produces the following warning:

warning   undeclared-dependency              one or more classes in nomulus:util:unspecified are required by your code directly                                                                                                       
                                                                                                                   
warning   unused-dependency                  one or more classes in nomulus:util:unspecified are required by your code directly (no auto-fix available)                                                                               

The lint.patch file shows that it wants project util to depend on itself...

diff --git a/util/build.gradle b/util/build.gradle                              
--- a/util/build.gradle                                                         
+++ b/util/build.gradle                                                         
@@ -47,4 +47,5 @@                                                               
   annotationProcessor deps['com.google.dagger:dagger-compiler']                
   testAnnotationProcessor deps['com.google.auto.value:auto-value']             
   testAnnotationProcessor deps['com.google.dagger:dagger-compiler']            
+    compile 'nomulus:util:unspecified'                                         
 } 

If I apply the patch the linter error will go away but when I run gradle clean it complains about this added dependency being unnecessary.

I think it is a nebula lint bug related to multi-projects as referenced in nebula-plugins/gradle-lint-plugin#44.

Since the warning does not result in failure I think we can just leave it there.


This change is Reviewable

@googlebot googlebot added the cla: yes label Nov 13, 2019
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Nov 13, 2019

This pull request fixes 1 alert when merging a4d7807 into 09aef04 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak
@jianglai jianglai requested review from weiminyu and mindhog Nov 13, 2019
Copy link
Member

mindhog left a comment

Reviewed 47 of 47 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @weiminyu)

@jianglai jianglai merged commit d552309 into google:master Nov 13, 2019
7 checks passed
7 checks passed
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java 1 fixed alert
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
cla/google All necessary CLAs are signed
code-review/reviewable 47 files reviewed (weiminyu)
Details
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@jianglai jianglai deleted the jianglai:gradle-6 branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.