Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circular dependency between core and util #379

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Nov 21, 2019

Created a new :common project and moved a minimum
number of classes to break the circular dependency
between the two projects. This gets rid of the
gradle lint dependency warnings.

Also separated api classes and testing helpers into
separate source sets in :common so that testing
classes may be restricted to test configurations.


This change is Reviewable

Created a new :common project and moved a minimum
number of classes to break the circular dependency
between the two projects. This gets rid of the
gradle lint dependency warnings.

Also separated api classes and testing helpers into
separate source sets in :common so that testing
classes may be restricted to test configurations.
@googlebot googlebot added the cla: yes label Nov 21, 2019
@weiminyu weiminyu requested review from jianglai and mindhog Nov 21, 2019
Copy link
Member

jianglai left a comment

This is great!

Reviewed 62 of 62 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mindhog and @weiminyu)


common/README.md, line 6 at r1 (raw file):

This is an intermediate step in untangling the circular dependencies
between :core and :util subprojects.

Do you want to add a TODO since this is intermediate?

@weiminyu weiminyu merged commit 9f0e241 into google:master Nov 21, 2019
6 of 7 checks passed
6 of 7 checks passed
code-review/reviewable 1 discussion left (mindhog, weiminyu)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:test-util branch Nov 21, 2019
jianglai added a commit to jianglai/nomulus that referenced this pull request Nov 22, 2019
* Break circular dependency between core and util

Created a new :common project and moved a minimum
number of classes to break the circular dependency
between the two projects. This gets rid of the
gradle lint dependency warnings.

Also separated api classes and testing helpers into
separate source sets in :common so that testing
classes may be restricted to test configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.