Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publish Cloud SQL schema jar to maven repo #383

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Nov 22, 2019

The original purpose of the maven publication is for
use by the server/schema compatibility tests. A command line
flag can direct a test run to use difference versions of
the schema jar. However, this won't work due to dependency
locking.


This change is Reviewable

The original purpose of the maven publication is for
use in server/schema compatibility tests. A commandline
flag can direct a test run to use difference versions of
the schema jar. However, this won't work due to dependency
locking.
@weiminyu weiminyu requested a review from jianglai Nov 22, 2019
@googlebot googlebot added the cla: yes label Nov 22, 2019
@jianglai

This comment has been minimized.

Copy link
Member

jianglai commented Nov 22, 2019

Solves #353

@weiminyu weiminyu merged commit 215de62 into google:master Nov 25, 2019
6 checks passed
6 checks passed
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:no-maven-schema branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.