Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow project dependency to use runtimeClasspath #395

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Dec 2, 2019

Project dependency should use runtimeClasspath. However, if
left unspecified, it uses 'default', which is the same as
the legacy 'runtime' configuration. (runtimeOnly dependencies
are left out).

Since runtimeClasspath cannot be referenced directly, we use
a custom config (deploy_jar) as a proxy.

By excluding testjars (leaked into 'compile' by third-party
dependencies) from runtimeClasspath, we prevent them from
getting into release artifacts.

Two meaningful changes in appengine_war.gradle and java_common.gradle

TESTED=Diffed contents of services/{module}/build/exploded-*
Only three jars are removed: hamcrest-core, junit, and
mockito-core.


This change is Reviewable

@googlebot googlebot added the cla: yes label Dec 2, 2019
@weiminyu weiminyu force-pushed the weiminyu:no-testjars-in-prod branch from a7f42dd to 5bb11f4 Dec 2, 2019
Project dependency should use runtimeClasspath. However, if
left unspecified, it uses 'default', which is the same as
the legacy 'runtime' configuration. (runtimeOnly dependencies
are left out).

Since runtimeClasspath cannot be referenced directly, we use
a custom config (deploy_jar) as a proxy.

By excluding testjars (leaked into 'compile' by third-party
dependencies) from runtimeClasspath, we prevent them from
getting into release artifacts.

Two meaningful changes in appengine_war.gradle and java_common.gradle

TESTED=Diffed contents of services/{module}/build/exploded-*
       Only three jars are removed: hamcrest-core, junit, and
       mockito-core.
@weiminyu weiminyu force-pushed the weiminyu:no-testjars-in-prod branch from 5bb11f4 to 8c5f570 Dec 2, 2019
@weiminyu weiminyu requested review from jianglai and mindhog Dec 2, 2019
@mindhog
mindhog approved these changes Dec 2, 2019
Copy link
Member

mindhog left a comment

Reviewed 48 of 48 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)

@weiminyu weiminyu merged commit f0fc53e into google:master Dec 2, 2019
7 checks passed
7 checks passed
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
cla/google All necessary CLAs are signed
code-review/reviewable 48 files reviewed (jianglai)
Details
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:no-testjars-in-prod branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.