Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new app to hold GenerateSqlSchemaCommand #409

Merged
merged 1 commit into from Dec 13, 2019
Merged

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Dec 11, 2019

GenerateSqlSchemaCommand starts postgresql using testcontainer.
This makes junit etc a runtime dependency, allowing them to get
into release artifacts.

By moving this command to a separate tool, we can remove junit
etc as compile/runtime dependency.

TESTED=Verified by running a registryTool command in alpha, and by running the new tool


This change is Reviewable

@googlebot googlebot added the cla: yes label Dec 11, 2019
@weiminyu weiminyu requested review from mindhog and hstonec and removed request for mindhog and hstonec Dec 11, 2019
@weiminyu weiminyu force-pushed the weiminyu:tool branch from 3bef32d to 56786da Dec 12, 2019
@weiminyu weiminyu requested review from hstonec and mindhog Dec 12, 2019
GenerateSqlSchemaCommand starts postgresql using testcontainer.
This makes junit etc a runtime dependency, allowing them to get
into release artifacts.

By moving this command to a separate tool, we can remove junit
etc as compile/runtime dependency.
@weiminyu weiminyu force-pushed the weiminyu:tool branch from 56786da to 560c50e Dec 13, 2019
Copy link
Member

mindhog left a comment

Reviewed 60 of 60 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hstonec)

Copy link
Collaborator

hstonec left a comment

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hstonec)

@weiminyu weiminyu merged commit 6aaf081 into google:master Dec 13, 2019
7 checks passed
7 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
code-review/reviewable 60 files reviewed
Details
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:tool branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.