Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kzip file for Kythe cross-referencing #424

Merged
merged 1 commit into from Jan 3, 2020
Merged

Conversation

@jianglai
Copy link
Member

jianglai commented Dec 28, 2019

This is set up per b/141716384.

This adds a pipeline that runs with every commits (needs to set up a trigger in GCB) and produces a [commit hash].kzip file in GCS that can be consumed by Grimoire to enable crossing-referencing on the Nomulus code base.

TESTED=Tested on alpha and successfully uploaded the merged kzip file to
GCS (https://storage.googleapis.com/domain-registry-alpha-codesearch/238d7858f13f3ad92094ae523363b3d8e146ef34.kzip).


This change is Reviewable

This is set up per b/141716384.

TESTED=Tested on alpha and successfully uploaded the merged kzip file to
GCS.
@googlebot googlebot added the cla: yes label Dec 28, 2019
@jianglai jianglai requested a review from CydeWeys Dec 28, 2019
Copy link
Member

CydeWeys left a comment

Can you expand on the commit description? When/how often is this new rule executed? This is strictly adding a new type of build and doesn't affect the existing types that we use for tests and deployments, right?

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @CydeWeys)

@jianglai

This comment has been minimized.

Copy link
Member Author

jianglai commented Jan 3, 2020

Can you expand on the commit description? When/how often is this new rule executed? This is strictly adding a new type of build and doesn't affect the existing types that we use for tests and deployments, right?

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @CydeWeys)

Done. PTAL.

Copy link
Member

CydeWeys left a comment

:lgtm:

Reviewable status: 0 of 8 files reviewed, all discussions resolved

@jianglai jianglai merged commit 7660381 into google:master Jan 3, 2020
6 of 7 checks passed
6 of 7 checks passed
code-review/reviewable 8 files left
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@jianglai jianglai deleted the jianglai:kythe branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.