Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradle JUnit to 4.13 #442

Merged
merged 1 commit into from Jan 14, 2020
Merged

Upgradle JUnit to 4.13 #442

merged 1 commit into from Jan 14, 2020

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Jan 13, 2020

Removed third_party/junit folder and all usage of the
JunitBackPort class. As a result, third_party is no
longer a Gradle subproject.

Minor code changes were needed to work around an
error-prone pattern: multiple statement in assertThrows'
runnable lambda.

Also third_party/activation and third_party/jsch. These
dependencies are loaded from remote maven repo. The local
copies are not in use.


This change is Reviewable

Removed third_party/junit folder and all usage of the
JunitBackPort class. As a result, third_party is no
longer a Gradle subproject.

Minor code changes were needed to work around an
error-prone pattern: multiple statement in assertThrows'
runnable lambda.

Also third_party/activation and third_party/jsch. These
dependencies are loaded from remote maven repo. The local
copies are not in use.
@weiminyu weiminyu requested review from jianglai and CydeWeys Jan 13, 2020
@googlebot googlebot added the cla: yes label Jan 13, 2020
@weiminyu weiminyu requested a review from mindhog Jan 13, 2020
Copy link
Member

CydeWeys left a comment

Yay finally!

Reviewable status: 0 of 336 files reviewed, all discussions resolved (waiting on @CydeWeys, @jianglai, and @mindhog)

Copy link
Member

CydeWeys left a comment

:lgtm:

Reviewable status: 0 of 336 files reviewed, all discussions resolved (waiting on @CydeWeys, @jianglai, and @mindhog)

Copy link
Member

jianglai left a comment

Are we sure that we can use upstream activation and jsch?

Reviewed 1 of 336 files at r1.
Reviewable status: 1 of 336 files reviewed, all discussions resolved (waiting on @jianglai and @mindhog)

@jianglai jianglai requested review from jianglai Jan 13, 2020
Copy link
Member

jianglai left a comment

Hmm, I guess you are right. dependencies.gradle shows that jsch and activation are both loaded from maven. I guess this must have been leftovers.

Reviewable status: 1 of 336 files reviewed, all discussions resolved (waiting on @jianglai and @mindhog)

@weiminyu weiminyu merged commit e106e25 into google:master Jan 14, 2020
6 of 7 checks passed
6 of 7 checks passed
code-review/reviewable 335 files left (jianglai, mindhog)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:3rd-party branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.