Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dump_golden_schema command in devtool #467

Merged
merged 4 commits into from Feb 3, 2020

Conversation

@mindhog
Copy link
Member

mindhog commented Jan 31, 2020

Add a dump_golden_schema command so that we can generate the golden schema
in-place without having to do the test -> fail -> copy -> test dance.

Refactor the SQL container functionality from GenerateSqlCommand. There is
some duplication of code between the dump command and SchemaTest which should
be dealt with in a subsequent PR.


This change is Reviewable

Add a dump_golden_schema command so that we can generate the golden schema
in-place without having to do the test -> fail -> copy -> test dance.

Refactor the SQL container functionality from GenerateSqlCommand.  There is
some duplication of code between the dump command and SchemaTest which should
be dealt with in a subsequent PR.
@mindhog mindhog requested a review from weiminyu Jan 31, 2020
@googlebot googlebot added the cla: yes label Jan 31, 2020
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Jan 31, 2020

This pull request introduces 1 alert when merging a48e68d into ce2f98f - view on LGTM.com

new alerts:

  • 1 for Potential output resource leak
Copy link
Collaborator

weiminyu left a comment

Reviewed 5 of 55 files at r1.
Reviewable status: 5 of 55 files reviewed, 1 unresolved discussion (waiting on @mindhog and @weiminyu)


core/src/nonprod/java/google/registry/tools/PostgresqlCommand.java, line 91 at r1 (raw file):

9.6.12

Current version is returned by NomulusPostgreSql.getDockerTag()

Copy link
Member Author

mindhog left a comment

Reviewable status: 2 of 55 files reviewed, 1 unresolved discussion (waiting on @weiminyu)


core/src/nonprod/java/google/registry/tools/PostgresqlCommand.java, line 91 at r1 (raw file):

Previously, weiminyu (Weimin Yu) wrote…
9.6.12

Current version is returned by NomulusPostgreSql.getDockerTag()

Done.

mindhog added 2 commits Jan 31, 2020
@weiminyu weiminyu self-requested a review Feb 3, 2020
Copy link
Collaborator

weiminyu left a comment

Reviewed 50 of 55 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @weiminyu)

@mindhog mindhog merged commit 76d8afe into google:master Feb 3, 2020
6 of 7 checks passed
6 of 7 checks passed
code-review/reviewable 1 discussion left (weiminyu)
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
cla/google All necessary CLAs are signed
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@mindhog mindhog deleted the mindhog:dump-golden branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.