Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gradle dependency cache shareable in GCB #479

Merged
merged 1 commit into from Feb 10, 2020
Merged

Conversation

@weiminyu
Copy link
Collaborator

weiminyu commented Feb 8, 2020

Make Gradle put its caches in the source tree so that
they can be preserved across steps. When left at their
default location, caches are lost after each step. This
results in repeated downloads of the same dependencies,
which might be the cause of the recent build errors.


This change is Reviewable

Make Gradle put its caches in the source tree so that
they can be preserved across steps. When left at their
default location, caches are lost after each step.
@weiminyu weiminyu requested review from CydeWeys, mindhog and sarahcaseybot Feb 8, 2020
@googlebot googlebot added the cla: yes label Feb 8, 2020
Copy link
Member

mindhog left a comment

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys and @sarahcaseybot)

@weiminyu weiminyu merged commit ce80278 into google:master Feb 10, 2020
7 checks passed
7 checks passed
LGTM analysis: Java No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
cla/google All necessary CLAs are signed
code-review/reviewable 4 files reviewed (CydeWeys, sarahcaseybot)
Details
kokoro-foss Kokoro build finished
Details
kokoro-internal Kokoro build finished
Details
@weiminyu weiminyu deleted the weiminyu:gcb-cache branch Feb 10, 2020
hstonec added a commit to hstonec/nomulus that referenced this pull request Feb 12, 2020
* Make Gradle dependency cache shareable in GCB

Make Gradle put its caches in the source tree so that
they can be preserved across steps. When left at their
default location, caches are lost after each step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.