Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spotless to the Gradle build #88

Merged
merged 3 commits into from Jun 19, 2019
Merged

Add Spotless to the Gradle build #88

merged 3 commits into from Jun 19, 2019

Conversation

gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Feb 8, 2019

This change is Reviewable

@gbrodman gbrodman added the do not merge Do not merge this PR. label Feb 8, 2019
@gbrodman gbrodman force-pushed the gb/spotless branch 5 times, most recently from 57d4406 to fc1eb1f Compare June 7, 2019 22:04
@gbrodman gbrodman force-pushed the gb/spotless branch 3 times, most recently from 8376bc5 to 93e315b Compare June 13, 2019 17:24
@gbrodman gbrodman requested a review from guyben13 June 13, 2019 18:09
@gbrodman gbrodman removed the do not merge Do not merge this PR. label Jun 13, 2019
Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gbrodman and @guyben13)


java_common.gradle, line 56 at r1 (raw file):

../gradlew

The gradlew file is at the same level. Shouldn't it be one dot instead of two? Same below.


java_common.gradle, line 56 at r1 (raw file):

spotlessCheck

Shouldn't we have this target be a dependent on the build task so that presubmit will prevent you from submitting malformed code?

Copy link
Collaborator Author

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @guyben13 and @jianglai)


java_common.gradle, line 56 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…
../gradlew

The gradlew file is at the same level. Shouldn't it be one dot instead of two? Same below.

Done.


java_common.gradle, line 56 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…
spotlessCheck

Shouldn't we have this target be a dependent on the build task so that presubmit will prevent you from submitting malformed code?

The Spotless plugin actually does that by default -- if you run "./gradlew build --dry-run" you can see that :spotlessCheck shows up as one of the tasks.

Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guyben13)

@gbrodman gbrodman merged commit e1db339 into master Jun 19, 2019
@gbrodman gbrodman deleted the gb/spotless branch June 19, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants