New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spotless to the Gradle build #88
Conversation
57d4406
to
fc1eb1f
Compare
8376bc5
to
93e315b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gbrodman and @guyben13)
java_common.gradle, line 56 at r1 (raw file):
../gradlew
The gradlew
file is at the same level. Shouldn't it be one dot instead of two? Same below.
java_common.gradle, line 56 at r1 (raw file):
spotlessCheck
Shouldn't we have this target be a dependent on the build task so that presubmit will prevent you from submitting malformed code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @guyben13 and @jianglai)
java_common.gradle, line 56 at r1 (raw file):
Previously, jianglai (Lai Jiang) wrote…
../gradlew
The
gradlew
file is at the same level. Shouldn't it be one dot instead of two? Same below.
Done.
java_common.gradle, line 56 at r1 (raw file):
Previously, jianglai (Lai Jiang) wrote…
spotlessCheck
Shouldn't we have this target be a dependent on the build task so that presubmit will prevent you from submitting malformed code?
The Spotless plugin actually does that by default -- if you run "./gradlew build --dry-run" you can see that :spotlessCheck shows up as one of the tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guyben13)
This change is