Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bazel build #94

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@jianglai
Copy link
Member

commented Jun 12, 2019

This change is Reviewable

@jianglai jianglai requested a review from mindhog Jun 12, 2019

@googlebot googlebot added the cla: yes label Jun 12, 2019

@jianglai jianglai requested a review from gbrodman Jun 12, 2019

@jianglai

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

+reviewer:@gbrodman

@gbrodman
Copy link
Collaborator

left a comment

Reviewed 1 of 144 files at r1.
Reviewable status: 1 of 144 files reviewed, all discussions resolved (waiting on @gbrodman and @mindhog)

@jianglai jianglai force-pushed the jianglai:delete-bazel branch from e07fbfa to 0143f36 Jun 13, 2019

@jianglai jianglai removed the do not merge label Jun 13, 2019

@jianglai jianglai force-pushed the jianglai:delete-bazel branch from 0143f36 to 2c928d1 Jun 13, 2019

@gbrodman
Copy link
Collaborator

left a comment

Reviewed 2 of 144 files at r1, 1 of 132 files at r2.
Reviewable status: 1 of 142 files reviewed, 1 unresolved discussion (waiting on @jianglai and @mindhog)


WORKSPACE, line 1 at r2 (raw file):

workspace(name = "domain_registry")

I'm still getting used to this UI; did you add this back in?

@jianglai jianglai force-pushed the jianglai:delete-bazel branch from 2c928d1 to f53ce62 Jun 13, 2019

@jianglai
Copy link
Member Author

left a comment

Reviewable status: 1 of 144 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @mindhog)


WORKSPACE, line 1 at r2 (raw file):

Previously, gbrodman wrote…

I'm still getting used to this UI; did you add this back in?

Sorry I meant to delete it, rebasing after your massive refactoring was difficult so I did a hard reset and started from scratch, and forgot to delete these files.

Remove bazel build
Also updated the build badge to reflect internal build status.

@jianglai jianglai force-pushed the jianglai:delete-bazel branch from f53ce62 to 12078ca Jun 13, 2019

@gbrodman
Copy link
Collaborator

left a comment

:lgtm:

Reviewable status: 1 of 144 files reviewed, all discussions resolved (waiting on @gbrodman and @mindhog)

@jianglai jianglai merged commit 8c5fc64 into google:master Jun 13, 2019

1 of 3 checks passed

code-review/reviewable 143 files left (gbrodman, mindhog)
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed

@jianglai jianglai deleted the jianglai:delete-bazel branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.