Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bazel build #94

Merged
merged 1 commit into from Jun 13, 2019
Merged

Remove Bazel build #94

merged 1 commit into from Jun 13, 2019

Conversation

@jianglai
Copy link
Member

@jianglai jianglai commented Jun 12, 2019

This change is Reviewable

@jianglai jianglai requested a review from mindhog Jun 12, 2019
@jianglai jianglai requested a review from gbrodman Jun 12, 2019
@jianglai
Copy link
Member Author

@jianglai jianglai commented Jun 12, 2019

+reviewer:@gbrodman

Copy link
Collaborator

@gbrodman gbrodman left a comment

Reviewed 1 of 144 files at r1.
Reviewable status: 1 of 144 files reviewed, all discussions resolved (waiting on @gbrodman and @mindhog)

Copy link
Collaborator

@gbrodman gbrodman left a comment

Reviewed 2 of 144 files at r1, 1 of 132 files at r2.
Reviewable status: 1 of 142 files reviewed, 1 unresolved discussion (waiting on @jianglai and @mindhog)


WORKSPACE, line 1 at r2 (raw file):

workspace(name = "domain_registry")

I'm still getting used to this UI; did you add this back in?

Copy link
Member Author

@jianglai jianglai left a comment

Reviewable status: 1 of 144 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @mindhog)


WORKSPACE, line 1 at r2 (raw file):

Previously, gbrodman wrote…

I'm still getting used to this UI; did you add this back in?

Sorry I meant to delete it, rebasing after your massive refactoring was difficult so I did a hard reset and started from scratch, and forgot to delete these files.

Also updated the build badge to reflect internal build status.
Copy link
Collaborator

@gbrodman gbrodman left a comment

:lgtm:

Reviewable status: 1 of 144 files reviewed, all discussions resolved (waiting on @gbrodman and @mindhog)

@jianglai jianglai merged commit 8c5fc64 into google:master Jun 13, 2019
1 of 3 checks passed
@jianglai jianglai deleted the delete-bazel branch Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants