This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Remove all uses of MagicMock #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
force-pushed
the
remove-magic-mock
branch
from
2937490
to
9ba4ea5
Compare
|
It seems py33 has started failing because of The |
|
We might as well drop 3.3 as well. This LGTM, the travis failure should be addressed separately. |
|
Commit itself looks fine; will this not get a passing build until 3.3 support is dropped? |
|
@nathanielmanistaatgoogle correct. I'll try to do that today (dealing with a product launch). |
|
TADA! I just made #604 |
MagicMock is a version of Mock with extra features for tests that need to test usage of magic methods (i.e. __nonzero__, __cmp__, etc.). None of the oauth2client tests actually need these extra features though.
dhermes
force-pushed
the
remove-magic-mock
branch
from
9ba4ea5
to
7c4acac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MagicMockis a version ofMockwith extra features for tests that need to test usage of magic methods (i.e.__nonzero__,__cmp__, etc.).None of the
oauth2clienttests actually need these extra features though.