Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix link to GettingStarted guide #126
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
Jun 22, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
googlebot
commented
Jun 22, 2018
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
philburk
approved these changes
Jun 23, 2018
Can merge after signing the agreement. Or we can make the change.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
atsushieno
Jun 23, 2018
Contributor
I believe I have entered everything I need for agreement but it's not updating the status. I don't mind if you go ahead and apply the changes by yourselves :-)
|
I believe I have entered everything I need for agreement but it's not updating the status. I don't mind if you go ahead and apply the changes by yourselves :-) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
commented
Jun 23, 2018
|
CLAs look good, thanks! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thank you for this fix! |
atsushieno commentedJun 22, 2018
No description provided.