Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use CMake based build on manylinux #2774

Closed
Mizux opened this issue Sep 17, 2021 · 0 comments
Closed

Can't use CMake based build on manylinux #2774

Mizux opened this issue Sep 17, 2021 · 0 comments
Assignees
Labels
Bug Build: CMake CMake based build issue Lang: Python Python wrapper issue OS: Linux GNU/Linux OS
Projects
Milestone

Comments

@Mizux
Copy link
Collaborator

Mizux commented Sep 17, 2021

Finding the Development component for Python (e.g. with FindPython3) fails if libpython isn't found.
However, it is ok for libpython not to exist if you simply want to compile Python extensions (as opposed to embedding Python in an application).
For example, the official Docker manylinux build images don't include libpython, to shrink the image size.
(see pypa/manylinux#484)

src: https://gitlab.kitware.com/cmake/cmake/-/issues/20425

In order to fix it we need to bump to CMake 3.18 and use Development.Module...

note: Development.Module is use to look for python header only since library is not available on manylinux.
note2: Development.Module has been introduced in CMake 3.18
ref: https://cmake.org/cmake/help/latest/module/FindPython3.html

@Mizux Mizux added Bug OS: Linux GNU/Linux OS Lang: Python Python wrapper issue Build: CMake CMake based build issue labels Sep 17, 2021
@Mizux Mizux added this to the v9.1 milestone Sep 17, 2021
@Mizux Mizux self-assigned this Sep 17, 2021
@Mizux Mizux added this to To do in ToDo via automation Sep 17, 2021
Mizux referenced this issue Sep 17, 2021
note: Development.Module is use to look for python header only
since library is not available on manylinux.
see: https://gitlab.kitware.com/cmake/cmake/-/issues/20425

note2: Development.Module has been introduced in CMake 3.18
ref: https://cmake.org/cmake/help/latest/module/FindPython3.html
@Mizux Mizux closed this as completed Sep 17, 2021
ToDo automation moved this from To do to Done Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build: CMake CMake based build issue Lang: Python Python wrapper issue OS: Linux GNU/Linux OS
Projects
ToDo
  
Done
Development

No branches or pull requests

1 participant