Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD compilation fail (amplmp issue) #2783

Closed
Mizux opened this issue Sep 22, 2021 · 0 comments
Closed

FreeBSD compilation fail (amplmp issue) #2783

Mizux opened this issue Sep 22, 2021 · 0 comments
Assignees
Labels
Bug Build: CMake CMake based build issue Build: Makefile Makefile based build issue Lang: C++ Native implementation issue OS: FreeBSD FreeBSD OS
Milestone

Comments

@Mizux
Copy link
Collaborator

Mizux commented Sep 22, 2021

When trying to build SCIP in our Vagrant generic/FreeBSD13 box (note a FreeBSD VirtualBox img) we are facing some compilation issue...

Observed

here the relevant trace (please notice we are building SCIP using FetchContent from our or-tools CMake based build)

default: [ 48%] Building CXX object _deps/scip-build/src/CMakeFiles/libscip.dir/amplmp/src/os.cpp.o
    default: cd /usr/home/vagrant/project/build/_deps/scip-build/src && /usr/bin/c++  -I/usr/home/vagrant/project/build/_deps/scip-src/src/amplmp/include -I/usr/home/vagrant/project/build/_deps/scip-build -I/usr/home/vagrant/project/build/_deps/scip-src/src -I/usr/home/vagrant/project/build/_deps/zlib-build -I/usr/home/vagrant/project/build/_deps/zlib-src -O3 -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -std=c++14 -MD -MT _deps/scip-build/src/CMakeFiles/libscip.dir/amplmp/src/os.cpp.o -MF CMakeFiles/libscip.dir/amplmp/src/os.cpp.o.d -o CMakeFiles/libscip.dir/amplmp/src/os.cpp.o -c /usr/home/vagrant/project/build/_deps/scip-src/src/amplmp/src/os.cpp
    default: /usr/home/vagrant/project/build/_deps/scip-src/src/amplmp/src/os.cpp:108:4: error: GetExecutablePath is not implemented for this system
    default: #  error GetExecutablePath is not implemented for this system
    default:    ^
    default: 1 error generated.
    default: *** Error code 1
    default: 
    default: Stop.
    default: make[2]: stopped in /usr/home/vagrant/project/build
    default: *** Error code 1
    default: 
    default: Stop.
    default: make[1]: stopped in /usr/home/vagrant/project/build
    default: *** Error code 1
    default: 
    default: Stop.
    default: make: stopped in /usr/home/vagrant/project/build
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

ref: https://github.com/google/or-tools/runs/3672547012?check_suite_focus=true

https://github.com/scipopt/scip/blob/9444e80869f6ac42723f3a43712ca6d4ce0c20dc/src/amplmp/src/os.cpp#L107-L109

Expected

Have support of FreeBSD so we can use it in OR-Tools or at least a dummy function instead of this error message breaking the build ;)
Also it seems that amplmp is only use to read some .nl file so it's sad to break the build for this "optional" feature...
https://github.com/scipopt/scip/blob/9444e80869f6ac42723f3a43712ca6d4ce0c20dc/src/amplmp/README#L2

Proposal

2min googling around:
https://fossies.org/linux/sccs/libschily/getexecpath.c seems to be a good starting point to fix amplmp source code

Annexe

Vagrantfile: https://github.com/google/or-tools/blob/master/cmake/vagrant/freebsd/cpp/Vagrantfile

@Mizux Mizux added Bug Build: CMake CMake based build issue Lang: C++ Native implementation issue Build: Makefile Makefile based build issue OS: FreeBSD FreeBSD OS labels Sep 22, 2021
@Mizux Mizux added this to the v9.1 milestone Sep 22, 2021
@Mizux Mizux self-assigned this Sep 22, 2021
@Mizux Mizux closed this as completed in e6ec6e6 Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build: CMake CMake based build issue Build: Makefile Makefile based build issue Lang: C++ Native implementation issue OS: FreeBSD FreeBSD OS
Projects
None yet
Development

No branches or pull requests

1 participant