Avoid using the default key in obm_export.py. #2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_770697165
branch
5 times, most recently
from
9ee2d34 to
522f541
Compare
When an obm module is initialized with apply_fn (and input_polymorphic_shape, constraints) as a mapping, it shouldn't use `constants.DEFAULT_METHOD_KEY` when users have specified all the settings for each of their functions. PiperOrigin-RevId: 772986086
copybara-service
bot
force-pushed
the
test_770697165
branch
from
522f541 to
2b191f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using the default key in obm_export.py.
When an obm module is initialized with apply_fn (and input_polymorphic_shape, constraints) as a mapping, it shouldn't use
constants.DEFAULT_METHOD_KEYwhen users have specified all the settings for each of their functions.