Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing commit from OSV-2021-237 seems wrong #16

Closed
carnil opened this issue Jan 4, 2022 · 2 comments
Closed

Fixing commit from OSV-2021-237 seems wrong #16

carnil opened this issue Jan 4, 2022 · 2 comments

Comments

@carnil
Copy link

carnil commented Jan 4, 2022

Hi

- fixed: 0bd6877f480a84657696a80adc13f9c5485dd996

references a fixing commit which though only removes a documentation snipped. Unless my bisect done is wrong, then the following should be the fixing commit:

https://git.ghostscript.com/?p=ghostpdl.git;a=commit;h=7861fcad13c497728189feafb41cd57b5b50ea25

git bisect start '--term-old' 'broken' '--term-new' 'fixed'
# broken: [45e765e59a45b46dcb05e8c729689a7c0574a48c] Fix some warnings caused by the gs FS api commit.
git bisect broken 45e765e59a45b46dcb05e8c729689a7c0574a48c
# fixed: [068172a75a11b6b26e25696eb49241e4ddf4fbc6] Dates and product string for 9.55.0 release
git bisect fixed 068172a75a11b6b26e25696eb49241e4ddf4fbc6
# broken: [35f6a9d9e2838069b5ba250cf26d016bc5ad3635] GPDL whitespace fixes.
git bisect broken 35f6a9d9e2838069b5ba250cf26d016bc5ad3635
# fixed: [331fcb49b62a615976711cccdd3ff9796152a323] Fix bug 703245: bitmap size exceeds buffer.
git bisect fixed 331fcb49b62a615976711cccdd3ff9796152a323
# broken: [3abfca2a925427962ed644872057f75c44afc0d8] Fix memory leak in pcl pdfmark implementation
git bisect broken 3abfca2a925427962ed644872057f75c44afc0d8
# broken: [fec1090d129630c23f425c6aae5a4a1308a973da] LGTM: Rejig s_A85E_process for goto's.
git bisect broken fec1090d129630c23f425c6aae5a4a1308a973da
# broken: [054d35268592bba2434dffdb3b36e4ad224adcf0] Guard against indirect /Length in an XRef stream
git bisect broken 054d35268592bba2434dffdb3b36e4ad224adcf0
# broken: [6f6c88f92f98d0f8340c29201c7536ec1a521efd] Sort tifftop.c dependency on jpeg headers
git bisect broken 6f6c88f92f98d0f8340c29201c7536ec1a521efd
# fixed: [0ca4ae94020a1e3b48c337759ccb9fc0b3af61ec] Bug 702910: Fix mkromfs for THREADSAFE build
git bisect fixed 0ca4ae94020a1e3b48c337759ccb9fc0b3af61ec
# broken: [b5e44d6709642727ee524cccd2b5ab09f2e48572] oss-fuzz 30795: handle remap_color failure in clist_begin_typed_image
git bisect broken b5e44d6709642727ee524cccd2b5ab09f2e48572
# fixed: [180419375973b9ce4664286a67106d712260ef7f] Remove .setpdfwrite from the documentation
git bisect fixed 180419375973b9ce4664286a67106d712260ef7f
# broken: [ea1624205c8e1ca936bd38a6095a0dd1880e7287] Fix hang condition detected on Windows release build.
git bisect broken ea1624205c8e1ca936bd38a6095a0dd1880e7287
# fixed: [7861fcad13c497728189feafb41cd57b5b50ea25] oss-fuzz 30715: Check stack limits after function evaluation.
git bisect fixed 7861fcad13c497728189feafb41cd57b5b50ea25
# first fixed commit: [7861fcad13c497728189feafb41cd57b5b50ea25] oss-fuzz 30715: Check stack limits after function evaluation.
@oliverchang
Copy link
Collaborator

Thanks for reporting this! I've fixed this up in f6950e9#diff-01bce735bf435d1c8ee1423787b03e7c36cf338139b62506d1f52926c56776ed.

Please feel free to send a PR in the future :)

Thanks again!

@carnil
Copy link
Author

carnil commented Jan 5, 2022

@oliverchang thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants