initial nokogiri libgumbo integration #11004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fuzzy-boiii23a is integrating a new project: |
|
We approve of adding thsi project. You just need to add a real user first. |
Update primary contact
Good to go now, thanks mate :) |
|
i resolved your comments @jonathanmetzman , please let me know if there are any more improvements i should make, thanks for the help it's much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
criticality score: 0.75414
approval: sparklemotion/nokogiri#2992
Please let me know if there is anything else that needs changing and just to note i'll be creating a pull request to integrate the harness into the upstream nokogiri repo sometime this week.