-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prometheus] Initial integration #3821
Conversation
Travis tests have failedHey @AdamKorcz, TravisBuddy Request Identifier: bf22dea0-96b2-11ea-a4b4-15e25fe479ac |
|
Hey @AdamKorcz, TravisBuddy Request Identifier: 0d63deb0-96b4-11ea-a4b4-15e25fe479ac |
|
👍 from my / Prometheus's side, thanks :) |
|
+1 to Prometheus. |
|
Hi @AdamKorcz we got an email about a fuzzing issue, but we are not able to access the issue, although we are part of the Google group prometheus-team@googlegroups.com that you added as a primary contact. Reading https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/, it seems the address has to be both a direct Google account, as well as an established committer in the project commit logs. Would we maybe have to add all of our personal email addresses here? |
|
@juliusv I am not sure that members of a group will have access to the bug reports. As far as I know, the email addresses that are listed in the project.yaml file will have access. |
|
@AdamKorcz Thanks! From https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/ it does sound like those are the requirements. I'll send a PR to update the configuration. As much as I'm thankful for the initial setup, I would also propose to remove your email from the direct bug report CCs, as security-sensitive issues should probably only be disclosed to the team managing the OSS project? |
|
@juliusv Not a problem with removing my email from the bug reports. |
|
@AdamKorcz Makes sense! Yep, will do! :) |
|
I also hope that we will be able to see retrospectively the fuzzing issue. |
|
@roidelapluie You will. FYI: I have experienced that it takes up to a day to view old bugs after having gained access. |
|
@juliusv There is one more thing that needs an update: The maintainer in the Dockerfile. |
|
@AdamKorcz Damn, now we actually have to maintain it ;) Thanks for pointing that out, here's a PR: #3906 |
This PR adds initial integration of the Cloud Native Computing Foundation graduated project, Prometheus.
A selection of the projects users can be found on the Prometheus website.
@juliusv is in the loop as well for this integration application.