Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus] Initial integration #3821

Merged
merged 2 commits into from
May 15, 2020
Merged

[Prometheus] Initial integration #3821

merged 2 commits into from
May 15, 2020

Conversation

AdamKorcz
Copy link
Collaborator

This PR adds initial integration of the Cloud Native Computing Foundation graduated project, Prometheus.

A selection of the projects users can be found on the Prometheus website.

@juliusv is in the loop as well for this integration application.

@TravisBuddy
Copy link

Travis tests have failed

Hey @AdamKorcz,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bf22dea0-96b2-11ea-a4b4-15e25fe479ac

@TravisBuddy
Copy link

Hey @AdamKorcz,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0d63deb0-96b4-11ea-a4b4-15e25fe479ac

@juliusv
Copy link
Contributor

juliusv commented May 15, 2020

👍 from my / Prometheus's side, thanks :)

@inferno-chromium
Copy link
Collaborator

+1 to Prometheus.

@inferno-chromium inferno-chromium merged commit 86148c5 into google:master May 15, 2020
@juliusv
Copy link
Contributor

juliusv commented May 29, 2020

Hi @AdamKorcz we got an email about a fuzzing issue, but we are not able to access the issue, although we are part of the Google group prometheus-team@googlegroups.com that you added as a primary contact. Reading https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/, it seems the address has to be both a direct Google account, as well as an established committer in the project commit logs. Would we maybe have to add all of our personal email addresses here?

@AdamKorcz
Copy link
Collaborator Author

@juliusv I am not sure that members of a group will have access to the bug reports. As far as I know, the email addresses that are listed in the project.yaml file will have access.
I don't think that maintainers have to be committers either in order to access the bug reports.
To get access, it will probably help to add personal email addresses to the maintainers list and log in with these. Feel free to leave them here in the thread, and I will be happy to add them.

@juliusv
Copy link
Contributor

juliusv commented May 29, 2020

@AdamKorcz Thanks! From https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/ it does sound like those are the requirements. I'll send a PR to update the configuration. As much as I'm thankful for the initial setup, I would also propose to remove your email from the direct bug report CCs, as security-sensitive issues should probably only be disclosed to the team managing the OSS project?

@AdamKorcz
Copy link
Collaborator Author

@juliusv Not a problem with removing my email from the bug reports.
The team behind the OSS-fuzz project have access to the bug reports, and usually project maintainers have different policies regarding the access to the bug reports. Since security vulnerabilities may come up, it can be a good idea to limit the access to the reports and have this group report further to relevant contributors.
If you are putting in a PR to update the project.yaml, would you mind removing my email in the same go?

@juliusv
Copy link
Contributor

juliusv commented May 29, 2020

@AdamKorcz Makes sense! Yep, will do! :)

@roidelapluie
Copy link
Contributor

I also hope that we will be able to see retrospectively the fuzzing issue.

@AdamKorcz
Copy link
Collaborator Author

AdamKorcz commented May 29, 2020

@roidelapluie You will. FYI: I have experienced that it takes up to a day to view old bugs after having gained access.

@AdamKorcz
Copy link
Collaborator Author

@juliusv There is one more thing that needs an update: The maintainer in the Dockerfile.

@juliusv
Copy link
Contributor

juliusv commented May 30, 2020

@AdamKorcz Damn, now we actually have to maintain it ;) Thanks for pointing that out, here's a PR: #3906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants