New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lua][draft: waiting for upstream] initial integration. #4653
Conversation
|
@DavidKorczynski Perhaps for more effective fuzzing it would good to add a dictionary with reserved Lua keywords (for example this one - google/fuzzing@ea35315) |
|
Thanks! I think there are a ton of ways we can improve Lua fuzzing, but the first step is to get the maintainers of Lua to be on board, which is being discussed on the mailing list atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions regarding code. Please mind than I'm not quite familiar with fuzzer but come from Lua mailing list.
|
@jonathanmetzman this should be ready now. However, could you address the comment by @ligurio above about Inc. vs LLC? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve.
I don't see the question. We prefer LLC though. I've fixed our templates to use LLC. |
Sorry, saw it and answered it. |
LuaJIT test code heavily based on Lua test [1]. How-to use: $ git clone https://github.com/google/AFL $ cd AFL && make $ cd ../tarantool $ mkdir build && cd build $ CC='../../AFL/afl-clang' CXX='../../AFL/afl-clang++' cmake -DENABLE_ASAN=ON .. $ ../../AFL/afl-fuzz -m 150 -x lua.dict -i in -o sync_dir -M fuzzer01 -- ./src/tarantool @@ $ ../../AFL/afl-fuzz -m 150 -x lua.dict -i in -o sync_dir -S fuzzer02 -- ./src/tarantool @@ 1. google/oss-fuzz#4653 Closes #5565
LuaJIT test code heavily based on Lua test [1]. How-to use: $ git clone https://github.com/google/AFL $ cd AFL && make $ cd ../tarantool $ mkdir build && cd build $ CC='../../AFL/afl-clang' CXX='../../AFL/afl-clang++' cmake -DENABLE_ASAN=ON .. $ ../../AFL/afl-fuzz -m 150 -x lua.dict -i in -o sync_dir -M fuzzer01 -- ./src/tarantool @@ $ ../../AFL/afl-fuzz -m 150 -x lua.dict -i in -o sync_dir -S fuzzer02 -- ./src/tarantool @@ 1. google/oss-fuzz#4653 Closes #5565
LuaJIT test code heavily based on Lua test [1]. How-to use: $ git clone https://github.com/google/AFL $ cd AFL && make $ cd ../tarantool $ mkdir build && cd build $ CC='../../AFL/afl-clang' CXX='../../AFL/afl-clang++' cmake -DENABLE_ASAN=ON .. $ ../../AFL/afl-fuzz -m 150 -x lua.dict -i in -o sync_dir -M fuzzer01 -- ./src/tarantool @@ $ ../../AFL/afl-fuzz -m 150 -x lua.dict -i in -o sync_dir -S fuzzer02 -- ./src/tarantool @@ ./test/fuzz/lua_fuzzer --dict=../test/static/corpus/lua.dict ../test/static/corpus/lua 1. google/oss-fuzz#4653 Closes #5565
| language: c | ||
| primary_contact: "roberto@inf.puc-rio.br" | ||
| auto_ccs: | ||
| - "fuzz@llua.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidKorczynski seems like a typo, shouldn't it be lua.org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're absolutely right, just did a PR #5215
Initial integration of Lua
For the record, this has been proposed on the Lua mailing list and am waiting for reply.