Use apt-get update && apt-get install, per Docker best practices #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/ I ran into this because I was getting errors locally, like: E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/d/dpkg/libdpkg-perl_1.18.4ubuntu1.1_all.deb 404 Not Found [IP: 91.189.88.149 80] It turns out you get these if you don't update, and the official best practices are to `run apt-get update && apt-get install`. In fact, running _any_ apt-get install command without the apt-get update && before it can result in unfortunate caching artifacts -- see "cache busting". (P.S. thanks to Peng on Freenode for helping me, I'm bad at Ubuntu.) So: sed -re \ 's/RUN apt-get ((-y )?(install|build-dep))/RUN apt-get update \&\& apt-get \1/' -i \ projects/**/Dockerfile I also manually fixed the cases that already ran apt-get update in their Dockerfile: dlplibs/Dockerfile grpc/Dockerfile libreoffice/Dockerfile
|
Thanks!! |
|
also: 7def2fc |
|
and f2dc317 |
|
Whoops, forgot about the templates and stuff. Thanks for the followups! |
tmatth
pushed a commit
to tmatth/oss-fuzz
that referenced
this pull request
Oct 22, 2018
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/ I ran into this because I was getting errors locally, like: E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/d/dpkg/libdpkg-perl_1.18.4ubuntu1.1_all.deb 404 Not Found [IP: 91.189.88.149 80] It turns out you get these if you don't update, and the official best practices are to `run apt-get update && apt-get install`. In fact, running _any_ apt-get install command without the apt-get update && before it can result in unfortunate caching artifacts -- see "cache busting". (P.S. thanks to Peng on Freenode for helping me, I'm bad at Ubuntu.) So: sed -re \ 's/RUN apt-get ((-y )?(install|build-dep))/RUN apt-get update \&\& apt-get \1/' -i \ projects/**/Dockerfile I also manually fixed the cases that already ran apt-get update in their Dockerfile: dlplibs/Dockerfile grpc/Dockerfile libreoffice/Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/
I ran into this because I was getting errors locally, like:
It turns out you get these if you don't update, and the official best practices are to
run apt-get update && apt-get install. In fact, running anyapt-get installcommand without theapt-get update &&before it can result in unfortunate caching artifacts -- ctrl+f for "cache busting". (P.S. thanks to Peng on Freenode for helping me, I'm bad at Ubuntu.)So:
I also manually fixed the cases that already ran apt-get update in their Dockerfile: