New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qubes-os] Initial integration of libqubes-rpc-filecopy fuzz target #679

Merged
merged 4 commits into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@paraschetal
Contributor

paraschetal commented Jun 16, 2017

No description provided.

paraschetal added some commits Jun 6, 2017

$CC $CFLAGS -c crc32.c
$CC $CFLAGS -c pack.c
$CC $CFLAGS -c unpack.c
ar rcs libqubes-rpc-filecopy.a ioall.o copy-file.o crc32.o unpack.o pack.o

This comment has been minimized.

@Dor1s

Dor1s Jun 16, 2017

Collaborator

Have you considered doing these build steps in a separate script or Makefile in the upstream?
This is fine for now, but if you're aiming an ideal integration, you'll have to move it upstream at some point.

This comment has been minimized.

@paraschetal

paraschetal Jun 16, 2017

Contributor

The goal is to have the fuzzing build scripts merged upstream once more targets are added or at least when I am sure that the fuzzer targets are efficient (I am still learning how to fuzz tbh 😅 ). I will update the build.sh script here when that happens. Will that be alright?

# limitations under the License.
#
################################################################################
export BACKEND_VMM=xen

This comment has been minimized.

@oliverchang

oliverchang Jun 16, 2017

Member

Fuzzers are run on VMs that don't support virtualization. Is this an issue here?

This comment has been minimized.

@paraschetal

paraschetal Jun 16, 2017

Contributor

Sorry, that environment variable was for an earlier build script using the qubes-builder. I forgot to remove it. Fixed now.

@Dor1s Dor1s merged commit 2d577f5 into google:master Jun 16, 2017

1 check passed

cla/google All necessary CLAs are signed

robertswiecki added a commit to robertswiecki/oss-fuzz that referenced this pull request Dec 18, 2017

[qubes-os] Initial integration of libqubes-rpc-filecopy fuzz target (g…
…oogle#679)

* Add Dockerfile for qubes-linux-utils build

* Add the outline for fuzzer build

* Integrate libqubes-rpc-filecopy

* Remove BACKEND_VMM env var

tmatth added a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018

[qubes-os] Initial integration of libqubes-rpc-filecopy fuzz target (g…
…oogle#679)

* Add Dockerfile for qubes-linux-utils build

* Add the outline for fuzzer build

* Integrate libqubes-rpc-filecopy

* Remove BACKEND_VMM env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment